-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix error nextRecover shouldn't be later than nextStart
#1214
scheduler: fix error nextRecover shouldn't be later than nextStart
#1214
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
…C/chaos-mesh into xiang/scheduler_fix
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 55.78% 47.89% -7.89%
==========================================
Files 68 77 +9
Lines 4383 4756 +373
==========================================
- Hits 2445 2278 -167
- Misses 1768 2239 +471
- Partials 170 239 +69
Continue to review full report at Codecov.
|
Signed-off-by: xiang <xiang13225080@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the
I will try to split them and make this scheduler easier to understand. |
#1221 will refine the scheduler, so this pr can be closed |
Signed-off-by: xiang xiang13225080@163.com
What problem does this PR solve?
fix issue #1207
it is easy to meet this error when create a chaos test with "scheduler": {"cron":"*/1 * * * * "}, "duration": "50s"
What is changed and how does it work?
when the chaos is the first time run, set the NextStart for it
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?