Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix networkchaos/iochaos recover slow (#1215) #1241

Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 3, 2020

Signed-off-by: Yang Keao keao.yang@yahoo.com

Cherry pick #1215 to release-1.0

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2020

/run-e2e-tests

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao YangKeao requested review from cwen0, fewdan and STRRL and removed request for cwen0 December 3, 2020 05:38
@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2020

/run-e2e-tests

@STRRL
Copy link
Member

STRRL commented Dec 3, 2020

e2e tests failed by "docker pull rate limit", should we cherry-pick #1205 to release-1.0?

@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2020

e2e tests failed by "docker pull rate limit", should we cherry-pick #1205 to release-1.0?

Good suggestion

@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2020

/run-e2e-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@bb3457d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.0    #1241   +/-   ##
==============================================
  Coverage               ?   48.43%           
==============================================
  Files                  ?       72           
  Lines                  ?     4391           
  Branches               ?        0           
==============================================
  Hits                   ?     2127           
  Misses                 ?     2055           
  Partials               ?      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3457d...57c8a64. Read the comment docs.

@STRRL
Copy link
Member

STRRL commented Dec 3, 2020

/run-e2e-tests

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member Author

YangKeao commented Dec 3, 2020

/merge

@ti-srebot
Copy link
Contributor

@YangKeao Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 0

@YangKeao YangKeao merged commit 75a3fcf into chaos-mesh:release-1.0 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants