Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dashboard homepage and some visible changes #1285

Merged
merged 29 commits into from
Dec 29, 2020

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Dec 15, 2020

What problem does this PR solve?

This PR introduces several changes (from #1283) that will be effected in v1.1.0:

And also, this PR has some minor bug fixes:

  • Can't view DNSChaos archives
  • Repeatedly request chaos-available-namespaces
  • Some bug fixes
  • Styles optimized

Some extra fixes were open below. When it's merged in master. Some functions will work as normal.

What is changed and how does it work?

In addition to the above changes, the dashboard UI has a layout change to adapt the recent features.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

I will follow up this PR chaos-mesh/website#24 to make sure its content is up to date.

Does this PR introduce a user-facing change?

Xnip2020-12-17_17-15-30

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #1285 (7e8048c) into master (7e9ff3f) will decrease coverage by 2.57%.
The diff coverage is 52.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   55.78%   53.21%   -2.58%     
==========================================
  Files          68       86      +18     
  Lines        4383     5418    +1035     
==========================================
+ Hits         2445     2883     +438     
- Misses       1768     2264     +496     
- Partials      170      271     +101     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8445c...7e8048c. Read the comment docs.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung mentioned this pull request Dec 17, 2020
14 tasks
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung marked this pull request as ready for review December 17, 2020 09:36
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@zhouqiang-cl
Copy link
Contributor

Very beautiful

WangXiangUSTC
WangXiangUSTC previously approved these changes Dec 18, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung changed the title refactor: dashboard homepage refactor: dashboard homepage and some visible changes Dec 23, 2020
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
ui/README.md Outdated Show resolved Hide resolved
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@g1eny0ung merge failed.

@WangXiangUSTC
Copy link
Contributor

/run-e2e-tests

@WangXiangUSTC WangXiangUSTC merged commit aa9de10 into chaos-mesh:master Dec 29, 2020
@g1eny0ung g1eny0ung deleted the refactor/home branch December 29, 2020 02:29
@dcalvin dcalvin mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download existing / running experiments YML
6 participants