Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing stressors checking (#1387) #1391

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 13, 2021

cherry-pick #1387 to release-1.1
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/1391

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/1391:release-1.1-f6e06375f651

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Resolve #1380.

This PR prevents unexpected behaviors when creating StressChaos.

What is changed and how does it work?

After changes, the CPU or Memory workers must be at least one bigger than zero.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@4033c8e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.1    #1391   +/-   ##
==============================================
  Coverage               ?   51.69%           
==============================================
  Files                  ?       78           
  Lines                  ?     4966           
  Branches               ?        0           
==============================================
  Hits                   ?     2567           
  Misses                 ?     2137           
  Partials               ?      262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4033c8e...5d84519. Read the comment docs.

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g1eny0ung g1eny0ung merged commit c9e1393 into chaos-mesh:release-1.1 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants