Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope pods' isolation problem (#1386) #1399

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 13, 2021

cherry-pick #1386 to release-1.1
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/1399

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/1399:release-1.1-36bb4f013eb8

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

This PR solves the pods' isolation problem between normal scope pods and network target scope pods.

Before these changes, when you get any scope pods, the others will sync at the same time. This is unexpected behavior.

What is changed and how does it work?

Pods will not sync between scopes.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan fewdan merged commit 1128625 into chaos-mesh:release-1.1 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants