Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some bug fixes related to the UI (#1430) #1438

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 21, 2021

cherry-pick #1430 to release-1.1
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/1438

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/1438:release-1.1-428ad16c0e75

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

This PR mainly fixes some bugs as below:

  • Correct the scheduler filling after loading an experiment from LoadFrom or external
  • Reduce re-render in newExperiments page when creating
  • Delay the data fetching after giving an operation on experiments (start, pause, etc.) to prevent the data from not updated
  • Split problem (in function helper1) in parsing labels and annotations (shouldn't cut all semicolon, only cut the first)

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@cwen0
Copy link
Member

cwen0 commented Jan 21, 2021

/run-e2e-tests

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit c312cab into chaos-mesh:release-1.1 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants