Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more settings in dashboard #1449

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Jan 25, 2021

What problem does this PR solve?

Resolve #1424.

What is changed and how does it work?

This PR mainly adds two options in settings, which you can see in the below screenshot.

Some minor changes:

  • Now LabelField will set values automatically after the input loses focus
  • Display the current version on the settings page

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

localhost_3000_dashboard_settings

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1449 (9e4e4ac) into master (7e9ff3f) will decrease coverage by 4.34%.
The diff coverage is 54.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   55.78%   51.43%   -4.35%     
==========================================
  Files          68       79      +11     
  Lines        4383     5014     +631     
==========================================
+ Hits         2445     2579     +134     
- Misses       1768     2172     +404     
- Partials      170      263      +93     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b7d25...9e4e4ac. Read the comment docs.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1118b9e into chaos-mesh:master Jan 27, 2021
@g1eny0ung g1eny0ung deleted the feat/more-settings branch January 27, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can chaos-dashboard dashboard show current version?
6 participants