chore(helm): allow install to namespace with numbers only #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
- Coverage 55.78% 52.03% -3.75%
==========================================
Files 68 80 +12
Lines 4383 5104 +721
==========================================
+ Hits 2445 2656 +211
- Misses 1768 2178 +410
- Partials 170 270 +100
Continue to review full report at Codecov.
|
|
Looks like you need to deal with CI and DCO first? Thank you. |
fixes chaos-mesh#1493 Signed-off-by: Radek Sedlák <r.sedlak@quadient.com>
fixes chaos-mesh#1493 Signed-off-by: Radek Sedlák <r.sedlak@quadient.com>
|
Hi, CI and DCO fixed |
fixes chaos-mesh#1493 Signed-off-by: Radek Sedlák <r.sedlak@quadient.com>
|
@cwen0 one more fix on targetNamespace |
fixes chaos-mesh#1493 Signed-off-by: Radek Sedlák <r.sedlak@quadient.com>
|
/merge |
|
/run-all-tests |
g1eny0ung
changed the title
|
@sedlakr merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #1493
What is changed and how does it work?
All used namespace vars are quoted to allow use number in namespace only
Checklist
Tests
Does this PR introduce a user-facing change?