Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models and controller of workflow http api #1527

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Mar 1, 2021

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

What is changed and how does it work?

Reference: #1521

This PR appends the models and controller for workflow HTTP API which communicates with the frontend.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

It could generate the expected swagger file.

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
Copy link
Member Author

STRRL commented Mar 2, 2021

/run-all-tests

Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
Copy link
Member Author

STRRL commented Mar 2, 2021

/run-all-tests

g1eny0ung
g1eny0ung previously approved these changes Mar 2, 2021
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😆

@g1eny0ung g1eny0ung mentioned this pull request Mar 2, 2021
6 tasks
Signed-off-by: STRRL <str_ruiling@outlook.com>
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member Author

STRRL commented Mar 3, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1527 (9a69340) into master (7e9ff3f) will decrease coverage by 3.58%.
The diff coverage is 59.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
- Coverage   55.78%   52.19%   -3.59%     
==========================================
  Files          68       82      +14     
  Lines        4383     5211     +828     
==========================================
+ Hits         2445     2720     +275     
- Misses       1768     2207     +439     
- Partials      170      284     +114     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2828f20...9a69340. Read the comment docs.

@cwen0
Copy link
Member

cwen0 commented Mar 3, 2021

/run-e2e-tests

@ti-srebot ti-srebot merged commit cb9c436 into chaos-mesh:master Mar 3, 2021
STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Mar 29, 2021
STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Mar 29, 2021
This reverts commit cb9c436.

Signed-off-by: STRRL <str_ruiling@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants