feat: apply multi type of chaos nodes with code generation #1621

STRRL · 2021-03-30T09:19:42Z

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

Make workflow supports all the type of chaos

What is changed and how does it work?

new method which mapping templateType and the CRD Kind, reuse the chaosKindMap
spawn the chaos object from EmbedChaos by templateType
tests on dependency of chaosKindMap
appending the example workflow with stress-chaos

Checklist

Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?

NONE

STRRL · 2021-03-30T09:19:49Z

/hold

Signed-off-by: STRRL <str_ruiling@outlook.com>

codecov-io · 2021-03-31T03:27:59Z

Codecov Report

Merging #1621 (8af5b58) into master (7e9ff3f) will decrease coverage by 5.34%.
The diff coverage is 55.17%.

@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
- Coverage   55.78%   50.43%   -5.35%     
==========================================
  Files          68       90      +22     
  Lines        4383     5601    +1218     
==========================================
+ Hits         2445     2825     +380     
- Misses       1768     2483     +715     
- Partials      170      293     +123

Impacted Files	Coverage Δ
api/v1alpha1/common_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/common_webhook.go	`100.00% <ø> (ø)`
api/v1alpha1/dnschaos_type.go	`0.00% <0.00%> (ø)`
api/v1alpha1/dnschaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/httpchaos_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/httpchaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/iochaos_types.go	`0.00% <ø> (-40.00%)`	⬇️
api/v1alpha1/jvmchaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/kernelchaos_types.go	`0.00% <ø> (-20.00%)`	⬇️
api/v1alpha1/kernelchaos_webhook.go	`94.11% <0.00%> (+8.93%)`	⬆️
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8968d9...8af5b58. Read the comment docs.

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL · 2021-03-31T09:05:56Z

/run-e2e-tests

STRRL · 2021-03-31T09:08:31Z

/hold cancel

STRRL · 2021-03-31T09:09:10Z

I think this PR is ready for review. 😁
/cc @chaos-mesh/committers
/cc @chaos-mesh/maintainers

Colstuwjx

rest LGTM.

helm/chaos-mesh/values.yaml

Colstuwjx · 2021-03-31T09:22:40Z

pkg/workflow/controllers/chaos_node_reconciler.go

@@ -51,51 +49,32 @@ func (it *ChaosNodeReconciler) Reconcile(request reconcile.Request) (reconcile.R
 		return reconcile.Result{}, client.IgnoreNotFound(err)
 	}

+	if !v1alpha1.IsChoasTemplateType(node.Spec.Type) {
+		return reconcile.Result{}, nil


Should we return an error here?

No, this reconciler would receive events about all workflownode, even type is not Type<Some>Chaos, and the v1alpha1.IsChoasTemplateType() plays as a filter.

Signed-off-by: STRRL <str_ruiling@outlook.com>

Colstuwjx

LGTM

AsterNighT · 2021-04-01T06:28:56Z

/lgtm

STRRL · 2021-04-01T09:37:06Z

Hi, as the GcpChaos has been merged #1526, this PR updates the definition of gcp chaos, so it need review again.

/cc @chaos-mesh/committers

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL · 2021-04-02T03:03:35Z

/run-e2e-tests

STRRL · 2021-04-02T03:19:32Z

/lgtm cancel

STRRL · 2021-04-02T09:55:47Z

/run-e2e-tests

STRRL · 2021-04-05T09:12:15Z

/run-e2e-tests

YangKeao

LGTM

cwen0

LGTM

ti-chi-bot · 2021-04-07T07:42:22Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

YangKeao
cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

STRRL · 2021-04-07T07:42:31Z

PTAL @AsterNighT @Colstuwjx

cwen0 · 2021-04-07T07:42:33Z

/merge

ti-chi-bot · 2021-04-07T07:42:34Z

This pull request has been accepted and is ready to merge.

Commit hash: 8af5b58

Colstuwjx · 2021-04-07T07:45:11Z

/lgtm

STRRL · 2021-04-07T08:02:13Z

/run-e2e-tests

ti-chi-bot · 2021-04-07T08:26:41Z

@STRRL: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added the do-not-merge/work-in-progress label Mar 30, 2021

ti-chi-bot added the do-not-merge/hold label Mar 30, 2021

ti-chi-bot requested review from siddontang and YangKeao March 30, 2021 09:19

ti-chi-bot added the size/XXL label Mar 30, 2021

feat: apply multi type of chaos nodes with code generation

b5a8ad9

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL force-pushed the workflow-more-type-of-chaos-nodes branch from c05f549 to b5a8ad9 Compare March 30, 2021 09:50

test: unit tests about the coupling with all chaosKindMap

5bf33e8

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL added 3 commits March 31, 2021 16:40

feat: fix the bug with unused chaosObject;

b215913

Signed-off-by: STRRL <str_ruiling@outlook.com>

feat: filtering with only ChaosTemplateType in chaos_node_reconciler

4de149c

Signed-off-by: STRRL <str_ruiling@outlook.com>

feat: appending stress-chaos within example workflow

6fe8a43

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL force-pushed the workflow-more-type-of-chaos-nodes branch from 3055934 to 6fe8a43 Compare March 31, 2021 09:03

STRRL marked this pull request as ready for review March 31, 2021 09:07

ti-chi-bot removed the do-not-merge/work-in-progress label Mar 31, 2021

STRRL added the component/workflow label Mar 31, 2021

ti-chi-bot removed the do-not-merge/hold label Mar 31, 2021

ti-chi-bot requested review from a team March 31, 2021 09:09

Colstuwjx reviewed Mar 31, 2021

View reviewed changes

STRRL added 2 commits March 31, 2021 17:43

chore: revert the modification on helm

922b357

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: update install.sh

aa37ef1

Signed-off-by: STRRL <str_ruiling@outlook.com>

Colstuwjx approved these changes Mar 31, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Mar 31, 2021

ti-chi-bot removed the status/LGT1 label Apr 1, 2021

ti-chi-bot removed the status/can-merge label Apr 1, 2021

ti-chi-bot requested a review from a team April 1, 2021 09:37

STRRL added 2 commits April 1, 2021 17:49

chore: make linters happy

9121243

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: make linters happy

9036807

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL mentioned this pull request Apr 1, 2021

Failed to list PR of chaos-mesh/chaos-mesh at the "PR Status" on prow.tidb.io ti-community-infra/tichi#457

Closed

1 task

fewdan mentioned this pull request Apr 1, 2021

support disk_list in gcpchaos disk-loss action #1631

Merged

6 tasks

ti-chi-bot removed the status/LGT2 label Apr 2, 2021

Merge branch 'master' into workflow-more-type-of-chaos-nodes

2491707

Merge branch 'master' into workflow-more-type-of-chaos-nodes

8af5b58

YangKeao approved these changes Apr 7, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Apr 7, 2021

cwen0 approved these changes Apr 7, 2021

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Apr 7, 2021

ti-chi-bot added the status/can-merge label Apr 7, 2021

Merge branch 'master' into workflow-more-type-of-chaos-nodes

edbcefc

Merge branch 'master' into workflow-more-type-of-chaos-nodes

284a967

ti-chi-bot merged commit 936d764 into chaos-mesh:master Apr 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: apply multi type of chaos nodes with code generation #1621

feat: apply multi type of chaos nodes with code generation #1621

STRRL commented Mar 30, 2021 •

edited

STRRL commented Mar 30, 2021

codecov-io commented Mar 31, 2021 •

edited

STRRL commented Mar 31, 2021

STRRL commented Mar 31, 2021

STRRL commented Mar 31, 2021

Colstuwjx left a comment

Colstuwjx Mar 31, 2021

STRRL Mar 31, 2021 •

edited

Colstuwjx left a comment

AsterNighT commented Apr 1, 2021

STRRL commented Apr 1, 2021 •

edited

STRRL commented Apr 2, 2021

STRRL commented Apr 2, 2021

STRRL commented Apr 2, 2021

STRRL commented Apr 5, 2021

YangKeao left a comment

cwen0 left a comment

ti-chi-bot commented Apr 7, 2021

STRRL commented Apr 7, 2021

cwen0 commented Apr 7, 2021

ti-chi-bot commented Apr 7, 2021

Colstuwjx commented Apr 7, 2021

STRRL commented Apr 7, 2021

ti-chi-bot commented Apr 7, 2021

feat: apply multi type of chaos nodes with code generation #1621

feat: apply multi type of chaos nodes with code generation #1621

Conversation

STRRL commented Mar 30, 2021 • edited

What problem does this PR solve?

What is changed and how does it work?

Checklist

Does this PR introduce a user-facing change?

STRRL commented Mar 30, 2021

codecov-io commented Mar 31, 2021 • edited

Codecov Report

STRRL commented Mar 31, 2021

STRRL commented Mar 31, 2021

STRRL commented Mar 31, 2021

Colstuwjx left a comment

Choose a reason for hiding this comment

Colstuwjx Mar 31, 2021

Choose a reason for hiding this comment

STRRL Mar 31, 2021 • edited

Choose a reason for hiding this comment

Colstuwjx left a comment

Choose a reason for hiding this comment

AsterNighT commented Apr 1, 2021

STRRL commented Apr 1, 2021 • edited

STRRL commented Apr 2, 2021

STRRL commented Apr 2, 2021

STRRL commented Apr 2, 2021

STRRL commented Apr 5, 2021

YangKeao left a comment

Choose a reason for hiding this comment

cwen0 left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Apr 7, 2021

STRRL commented Apr 7, 2021

cwen0 commented Apr 7, 2021

ti-chi-bot commented Apr 7, 2021

Colstuwjx commented Apr 7, 2021

STRRL commented Apr 7, 2021

ti-chi-bot commented Apr 7, 2021

STRRL commented Mar 30, 2021 •

edited

codecov-io commented Mar 31, 2021 •

edited

STRRL Mar 31, 2021 •

edited

STRRL commented Apr 1, 2021 •

edited