Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HttpChaos #1858

Merged
merged 31 commits into from
May 27, 2021
Merged

Implement HttpChaos #1858

merged 31 commits into from
May 27, 2021

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented May 18, 2021

Implementing HttpChaos through reconciler.

Signed-off-by: hexilee i@hexilee.me

Signed-off-by: hexilee <i@hexilee.me>
@ti-chi-bot ti-chi-bot requested a review from YangKeao May 18, 2021 10:08
@Hexilee Hexilee changed the title remove webhook of podhttpchaos PodHttpChaos through reconciler May 18, 2021
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
@Hexilee Hexilee changed the title PodHttpChaos through reconciler Implement HttpChaos. May 20, 2021
@Hexilee Hexilee marked this pull request as ready for review May 20, 2021 04:34
@Hexilee Hexilee changed the title Implement HttpChaos. Implement HttpChaos May 20, 2021
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
@YangKeao
Copy link
Member

YangKeao commented May 25, 2021

  1. Please reduce the default log level of tproxy. The TRACE level is too noisy.
  2. It seems that the Recover e2e test is not stable. Maybe stop().await consumes too much time (but I'm not sure).
  3. BTW, can it stop when the rules are empty?

Hexilee and others added 4 commits May 25, 2021 19:07
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: YangKeao <keao.yang@yahoo.com>
…-mesh into pr/Hexilee/1858

Signed-off-by: YangKeao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
Signed-off-by: hexilee <i@hexilee.me>
@YangKeao
Copy link
Member

As it has passed the test, I will merge this PR 👍

🍻 HTTPChaos finally comes to Chaos Mesh.

@YangKeao YangKeao merged commit 69ac5ba into chaos-mesh:nirvana May 27, 2021
@satyaprakash1729
Copy link

As it has passed the test, I will merge this PR 👍

🍻 HTTPChaos finally comes to Chaos Mesh.

@YangKeao Thanks for bringing this to life! It'll be a great addition to Chaos-Mesh.
Curious to understand how this whole thing works? Basically which component in K8s cluster will honor the config and does the response transformation.

@agilob
Copy link

agilob commented Aug 2, 2021

Any ETA for a stable release which includes HTTPChaos?

@Hexilee
Copy link
Member Author

Hexilee commented Aug 2, 2021

Any ETA for a stable release which includes HTTPChaos?

Actually, the v2.0.0 includes HTTPChaos, but there are no dashboard supports yet, you can create the experiment by YAML config. The docs of v0.2.0 are going to release, you can preview them here.

@Hexilee
Copy link
Member Author

Hexilee commented Aug 2, 2021

As it has passed the test, I will merge this PR 👍
🍻 HTTPChaos finally comes to Chaos Mesh.

@YangKeao Thanks for bringing this to life! It'll be a great addition to Chaos-Mesh.
Curious to understand how this whole thing works? Basically which component in K8s cluster will honor the config and does the response transformation.

Hi, you can refer to the rs-tproxy repo to learn about how things work.

@agilob
Copy link

agilob commented Aug 2, 2021

Thanks, I missed 2.0.0 release. I'm planning to use yaml experiments only, so that's ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants