Schedule workflow #1861

AsterNighT · 2021-05-19T03:21:01Z

What problem does this PR solve?

What is changed and how does it work?

Checklist

Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: AsterNighT <klxjt99@outlook.com>

* feat: apis for endtime and status Signed-off-by: STRRL <str_ruiling@outlook.com> * feat: refactor workflow entry reconciler, update conditions in stastus Signed-off-by: STRRL <str_ruiling@outlook.com> * feat: update the end time of workflow Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: fix comments and typos Signed-off-by: STRRL <str_ruiling@outlook.com> * test: fix test cases Signed-off-by: STRRL <str_ruiling@outlook.com> * fix: fix the condition on updating end time of workflow Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Signed-off-by: AsterNighT <klxjt99@outlook.com>

AsterNighT · 2021-05-20T04:22:52Z

I think it's ready for review. @STRRL @YangKeao

sonatype-lift · 2021-05-20T04:28:31Z

pkg/chaosctl/common/common.go

@@ -183,7 +181,7 @@ func InitClientSet() (*ClientSet, error) {
 // GetPods returns pod list and corresponding chaos daemon
 func GetPods(ctx context.Context, chaosName string, status v1alpha1.ChaosStatus, selectorSpec v1alpha1.PodSelectorSpec, c client.Client) ([]v1.Pod, []v1.Pod, error) {
 	// get podName
-	failedMessage := status.FailedMessage
+	failedMessage := ""
 	if failedMessage != "" {


opt.semgrep.eqeq-is-bad: useless comparison operation failedMessage == failedMessage or failedMessage != failedMessage
(at-me in a reply with help or ignore)

@Muse-Dev ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @muse-dev unignore.

Signed-off-by: AsterNighT <klxjt99@outlook.com>

STRRL

Hi @AsterNighT , I try to apply that CRD into my kubernetes clusters (tried on v1.15.12 and v1.20.2), both of them told me:

CustomResourceDefinition.apiextensions.k8s.io "schedules.chaos-mesh.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[workflow].type: Required value: must not be empty for specified object fields

also happends on workflownodes.chaos-mesh.org, workflows.chaos-mesh.org

Seems the controller-gen does NOT make the correct definition of Workflow in EmbededChaos.

FYI, then I tried to regenerate CRD YAML with controller-gen@v0.4.1 and controller-gen@v0.5.0, only controller-gen@v0.5.0 works.

STRRL · 2021-05-25T05:11:41Z

config/crd/bases/chaos-mesh.org_schedules.yaml

@@ -1898,6 +1898,7 @@ spec:
              description: 'TODO: use a custom type, as `TemplateType` contains other
                possible values'
              type: string
+            workflow: {}


I think this is the reason that makes the CRD invalid.

I separate schedule totally from workflow. It no longer use embeded chaos any more, but generate its own types. Does it work now?

Signed-off-by: AsterNighT <klxjt99@outlook.com>

AsterNighT · 2021-05-25T07:10:25Z

Oh my, 7162+! What the hell is that?

STRRL

LGTM

I am sure we will refactor the definition of EmbedChaos or ScheduleItem in the future.

YangKeao · 2021-05-25T08:19:08Z

/lgtm

ti-chi-bot · 2021-05-25T08:19:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL
YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

YangKeao · 2021-05-25T08:19:20Z

/merge

ti-chi-bot · 2021-05-25T08:19:21Z

This pull request has been accepted and is ready to merge.

Commit hash: 47132da

* Simplify implementation Signed-off-by: AsterNighT <klxjt99@outlook.com> * provide jvmchaos Signed-off-by: AsterNighT <klxjt99@outlook.com> * ignore not found Signed-off-by: AsterNighT <klxjt99@outlook.com> * PodIOChaos through reconciler (#1836) * podnetworkchaos through reconciler Signed-off-by: YangKeao <keao.yang@yahoo.com> * manage status machine in common controller Signed-off-by: YangKeao <keao.yang@yahoo.com> * fix subresource observation Signed-off-by: YangKeao <keao.yang@yahoo.com> * make check and remove comments Signed-off-by: YangKeao <keao.yang@yahoo.com> * fix according to review Signed-off-by: YangKeao <keao.yang@yahoo.com> * bootstrap podiochaos Signed-off-by: YangKeao <keao.yang@yahoo.com> * podiochaos implementation through reconciler Signed-off-by: YangKeao <keao.yang@yahoo.com> * fix iochaos owns watch Signed-off-by: YangKeao <keao.yang@yahoo.com> * use simple list to map podxxxchaos to xxxchaos in controller Signed-off-by: YangKeao <keao.yang@yahoo.com> * fix a typo in the comment Signed-off-by: YangKeao <keao.yang@yahoo.com> * Schedule workflow (#1861) * tmp Signed-off-by: AsterNighT <klxjt99@outlook.com> * feat: apis for workflow endtime and status (#1828) * feat: apis for endtime and status Signed-off-by: STRRL <str_ruiling@outlook.com> * feat: refactor workflow entry reconciler, update conditions in stastus Signed-off-by: STRRL <str_ruiling@outlook.com> * feat: update the end time of workflow Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: fix comments and typos Signed-off-by: STRRL <str_ruiling@outlook.com> * test: fix test cases Signed-off-by: STRRL <str_ruiling@outlook.com> * fix: fix the condition on updating end time of workflow Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * implement gc for workflow Signed-off-by: AsterNighT <klxjt99@outlook.com> * Apply generate Signed-off-by: AsterNighT <klxjt99@outlook.com> * Update test and yam; Signed-off-by: AsterNighT <klxjt99@outlook.com> * Fix type assertion issues Signed-off-by: AsterNighT <klxjt99@outlook.com> * Add todo Signed-off-by: AsterNighT <klxjt99@outlook.com> * Separate schedule from workflow Signed-off-by: AsterNighT <klxjt99@outlook.com> Co-authored-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * Simplify implementation Signed-off-by: AsterNighT <klxjt99@outlook.com> * provide jvmchaos Signed-off-by: AsterNighT <klxjt99@outlook.com> * ignore not found Signed-off-by: AsterNighT <klxjt99@outlook.com> * fix selector in jvmchaos Signed-off-by: YangKeao <keao.yang@yahoo.com> * update example Signed-off-by: AsterNighT <klxjt99@outlook.com> Co-authored-by: YangKeao <keao.yang@yahoo.com> Co-authored-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot added do-not-merge/work-in-progress contribution labels May 19, 2021

ti-chi-bot requested review from g1eny0ung and STRRL May 19, 2021 03:21

ti-chi-bot added the size/XXL label May 19, 2021

AsterNighT removed request for g1eny0ung and STRRL May 19, 2021 03:58

AsterNighT mentioned this pull request May 19, 2021

add condition controller #1832

Merged

AsterNighT and others added 6 commits May 20, 2021 11:29

tmp

30ab19a

Signed-off-by: AsterNighT <klxjt99@outlook.com>

implement gc for workflow

8c6356e

Signed-off-by: AsterNighT <klxjt99@outlook.com>

Apply generate

ab7cded

Signed-off-by: AsterNighT <klxjt99@outlook.com>

Update test and yam;

45e7641

Signed-off-by: AsterNighT <klxjt99@outlook.com>

Fix type assertion issues

f2a0e19

Signed-off-by: AsterNighT <klxjt99@outlook.com>

AsterNighT force-pushed the schedule-workflow branch from 2b6d8b3 to f2a0e19 Compare May 20, 2021 04:19

AsterNighT marked this pull request as ready for review May 20, 2021 04:22

ti-chi-bot removed the do-not-merge/work-in-progress label May 20, 2021

sonatype-lift bot reviewed May 20, 2021

View reviewed changes

Add todo

037a477

Signed-off-by: AsterNighT <klxjt99@outlook.com>

AsterNighT added this to the Controller Nirvana milestone May 20, 2021

STRRL reviewed May 25, 2021

View reviewed changes

Separate schedule from workflow

47132da

Signed-off-by: AsterNighT <klxjt99@outlook.com>

AsterNighT requested review from STRRL, YangKeao and Hexilee May 25, 2021 07:12

STRRL approved these changes May 25, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label May 25, 2021

ti-chi-bot added status/LGT2 and removed status/LGT1 labels May 25, 2021

ti-chi-bot added the status/can-merge label May 25, 2021

Merge branch 'nirvana' into schedule-workflow

e9cea03

ti-chi-bot merged commit 30f6ea2 into chaos-mesh:nirvana May 25, 2021

YangKeao mentioned this pull request May 31, 2021

Merge nirvana into master #1908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schedule workflow #1861

Schedule workflow #1861

AsterNighT commented May 19, 2021

AsterNighT commented May 20, 2021

sonatype-lift bot May 20, 2021

AsterNighT May 20, 2021

sonatype-lift bot May 20, 2021

STRRL left a comment •

edited

STRRL May 25, 2021

AsterNighT May 25, 2021

AsterNighT commented May 25, 2021

STRRL left a comment

YangKeao commented May 25, 2021

ti-chi-bot commented May 25, 2021

YangKeao commented May 25, 2021

ti-chi-bot commented May 25, 2021

Schedule workflow #1861

Schedule workflow #1861

Conversation

AsterNighT commented May 19, 2021

What problem does this PR solve?

What is changed and how does it work?

Checklist

Does this PR introduce a user-facing change?

AsterNighT commented May 20, 2021

sonatype-lift bot May 20, 2021

Choose a reason for hiding this comment

AsterNighT May 20, 2021

Choose a reason for hiding this comment

sonatype-lift bot May 20, 2021

Choose a reason for hiding this comment

STRRL left a comment • edited

Choose a reason for hiding this comment

STRRL May 25, 2021

Choose a reason for hiding this comment

AsterNighT May 25, 2021

Choose a reason for hiding this comment

AsterNighT commented May 25, 2021

STRRL left a comment

Choose a reason for hiding this comment

YangKeao commented May 25, 2021

ti-chi-bot commented May 25, 2021

YangKeao commented May 25, 2021

ti-chi-bot commented May 25, 2021

STRRL left a comment •

edited