Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pause/start schedule api #1942

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Jun 7, 2021

Signed-off-by: “fewdan” fewdan@hotmail.com

What problem does this PR solve?

add pause/start schedule api

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
Copy link
Member Author

fewdan commented Jun 7, 2021

@g1eny0ung
Need modify the UI, so PTAL.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/apiserver/schedule/schedule.go Outdated Show resolved Hide resolved
pkg/apiserver/schedule/schedule.go Outdated Show resolved Hide resolved
pkg/apiserver/schedule/schedule.go Outdated Show resolved Hide resolved
Signed-off-by: “fewdan” <fewdan@hotmail.com>
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@g1eny0ung
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ebd981

@ti-chi-bot
Copy link
Member

@fewdan: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cwen0 cwen0 merged commit 0a51d41 into chaos-mesh:master Jun 7, 2021
@fewdan fewdan deleted the api_pause_schedule branch June 7, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants