Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the coredns image version for helm value #2226

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Update the coredns image version for helm value #2226

merged 1 commit into from
Aug 17, 2021

Conversation

ReigenDing
Copy link
Contributor

@ReigenDing ReigenDing commented Aug 16, 2021 •
edited
Loading

Update helm coredns version from 0.2.0 to 0.2.1

What problem does this PR solve?

bug of codns chaos serve rpc retrun nil

What is changed and how it works?

What's Changed:

from image: pingcap/coredns:v0.2.0
to image: pingcap/coredns:v0.2.1
according to #2163 (comment)

Related changes

  • PR to update chaos-mesh/website/chaos-mesh/website-zh:
  • Need to update Chaos Dashboard component, related issue:
  • Need to cheery-pick to the release branch

Tests

  • E2E test

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

update coredns image to 0.2.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #2226 (e428096) into master (7e9ff3f) will decrease coverage by 13.67%.
The diff coverage is 41.70%.

❗ Current head e428096 differs from pull request most recent head 0c7ceb4. Consider uploading reports for the commit 0c7ceb4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2226       +/-   ##
===========================================
- Coverage   55.78%   42.10%   -13.68%     
===========================================
  Files          68      126       +58     
  Lines        4383     8678     +4295     
===========================================
+ Hits         2445     3654     +1209     
- Misses       1768     4692     +2924     
- Partials      170      332      +162
Impacted Files Coverage Δ
api/v1alpha1/awschaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/gcpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <0.00%> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <0.00%> (-20.00%) ⬇️
api/v1alpha1/kinds.go 23.52% <0.00%> (-3.14%) ⬇️
api/v1alpha1/networkchaos_types.go 0.00% <0.00%> (-22.99%) ⬇️
api/v1alpha1/podchaos_types.go 0.00% <0.00%> (-37.15%) ⬇️
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12acd0c...0c7ceb4. Read the comment docs.

@fewdan
Copy link
Member

fewdan commented Aug 17, 2021

Thank you for your contribution, please fix the DCO issue first. You can refer to it.

Update the coredns image version for helm value
0c7ceb4 
Signed-off-by: qiao <qiao@qiaodeMacBook-Air.local>
fewdan
fewdan approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WangXiangUSTC
WangXiangUSTC approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0c7ceb4

@WangXiangUSTC WangXiangUSTC mentioned this pull request Aug 17, 2021
Closed
@STRRL
Copy link
Member

STRRL commented Aug 17, 2021

/run-e2e-tests

@STRRL
Copy link
Member

STRRL commented Aug 17, 2021

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 2cf486a into chaos-mesh:master Aug 17, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2021
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #2230

ti-chi-bot pushed a commit that referenced this pull request Aug 18, 2021
@ti-srebot
Update the coredns image version for helm value (#2226) (#2230)
1f58613 
Signed-off-by: qiao <qiao@qiaodeMacBook-Air.local>

Co-authored-by: qiao <qiao@qiaodeMacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@fewdan fewdan fewdan approved these changes

@cwen0 cwen0 Awaiting requested review from cwen0

@Gallardot Gallardot Awaiting requested review from Gallardot

Assignees
No one assigned
Labels
contribution needs-cherry-pick-release-2.0 size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ReigenDing @ti-chi-bot @codecov-commenter @fewdan @WangXiangUSTC @STRRL @ti-srebot