Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use host-sys in fusedev device priviledge granting #2242

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

As the chaos-daemon tried to write device.allow in cgroup, but used the /sys/fs/cgroup as the root path, it will give an error. The root path of host cgroup should be /host-sys/fs/cgroup.

What is changed and how it works?

Modify sys to host-sys.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #2242 (29f3169) into master (7e9ff3f) will decrease coverage by 14.86%.
The diff coverage is 37.94%.

❗ Current head 29f3169 differs from pull request most recent head 24e1eb0. Consider uploading reports for the commit 24e1eb0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2242       +/-   ##
===========================================
- Coverage   55.78%   40.91%   -14.87%     
===========================================
  Files          68      126       +58     
  Lines        4383     8507     +4124     
===========================================
+ Hits         2445     3481     +1036     
- Misses       1768     4691     +2923     
- Partials      170      335      +165     
Impacted Files Coverage Δ
api/v1alpha1/awschaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/gcpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <0.00%> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <0.00%> (-20.00%) ⬇️
api/v1alpha1/kinds.go 23.52% <0.00%> (-3.14%) ⬇️
api/v1alpha1/networkchaos_types.go 0.00% <0.00%> (-22.99%) ⬇️
api/v1alpha1/podchaos_types.go 0.00% <0.00%> (-37.15%) ⬇️
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a16a4...24e1eb0. Read the comment docs.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

@cwen0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member Author

/run-e2e-tests

@cwen0
Copy link
Member

cwen0 commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dbefeec

@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #2246

ti-chi-bot pushed a commit that referenced this pull request Aug 23, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants