Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(StressChaos): containerNames problem #2245

Merged
merged 4 commits into from
Aug 25, 2021
Merged

fix(StressChaos): containerNames problem #2245

merged 4 commits into from
Aug 25, 2021

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Unify the containerNames field on front-end and back-end.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update chaos-mesh/website/chaos-mesh/website-zh:
  • Need to update Chaos Dashboard component, related issue:
  • Need to cheery-pick to the release branch

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

@g1eny0ung
fix(StressChaos): containerNames problem
8917c52 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung requested review from fewdan and cwen0 August 20, 2021 08:12
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@g1eny0ung
fix: ci
4144958 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@1f58613). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 06f04b6 differs from pull request most recent head 4144958. Consider uploading reports for the commit 4144958 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2245   +/-   ##
==============================================
  Coverage               ?   42.88%           
==============================================
  Files                  ?      128           
  Lines                  ?     8854           
  Branches               ?        0           
==============================================
  Hits                   ?     3797           
  Misses                 ?     4728           
  Partials               ?      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f58613...4144958. Read the comment docs.

WangXiangUSTC
WangXiangUSTC approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwen0
cwen0 reviewed Aug 24, 2021
View reviewed changes
pkg/apiserver/experiment/experiment.go
@@ -373,16 +373,13 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo, kubeCli client.Cli
Mode: v1alpha1.PodMode(exp.Scope.Mode),
Value: exp.Scope.Value,
},
ContainerNames: exp.Target.StressChaos.ContainerNames,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panic here if exp.Target.StressChaos.CintainerName is nil.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be an empty array because of the omitempty option?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right

cwen0
cwen0 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Aug 24, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4144958

@cwen0
Copy link
Member

cwen0 commented Aug 25, 2021

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit bcffe0d into chaos-mesh:release-2.0 Aug 25, 2021
@g1eny0ung g1eny0ung deleted the fix/stresschaos branch August 25, 2021 07:20
@fewdan fewdan mentioned this pull request Sep 10, 2021
Closed
@Muscule
Copy link

Muscule commented Sep 10, 2021

When this fix will be available?

@cwen0
Copy link
Member

cwen0 commented Sep 23, 2021 •
edited
Loading

When this fix will be available?

@Muscule v2.0.1 included this fix. You can upgrade to v2.0.1
https://github.com/chaos-mesh/chaos-mesh/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@cwen0 cwen0 cwen0 approved these changes

@fewdan fewdan Awaiting requested review from fewdan

Assignees
No one assigned
Labels
component/dashboard size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@g1eny0ung @ti-chi-bot @codecov-commenter @cwen0 @Muscule @WangXiangUSTC