Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kind apiVersion to v1alpha4 (#2258) #2260

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 30, 2021

cherry-pick #2258 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/2260

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/2260:release-2.0-25db3b4dcff3

What problem does this PR solve?

Problem Summary:

start to create kubernetes cluster kindERROR: failed to create cluster: unknown apiVersion: kind.sigs.k8s.io/v1alpha3

What is changed and how it works?

What's Changed:

  1. upgrade kind.sigs.k8s.io/v1alpha3 to kind.x-k8s.io/v1alpha4, v1alpha3 kind config is no longer supported since v0.9.0
  2. use v0.11.1 as the default version of kind

Related changes

  • PR to update chaos-mesh/website/chaos-mesh/website-zh:
  • Need to update Chaos Dashboard component, related issue:
  • Need to cheery-pick to the release branch

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

Signed-off-by: cwen0 <cwenyin0@gmail.com>
Signed-off-by: cwen0 <cwenyin0@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@2989e66). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2260   +/-   ##
==============================================
  Coverage               ?   42.98%           
==============================================
  Files                  ?      128           
  Lines                  ?     8854           
  Branches               ?        0           
==============================================
  Hits                   ?     3806           
  Misses                 ?     4719           
  Partials               ?      329           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2989e66...5331322. Read the comment docs.

@STRRL
Copy link
Member

STRRL commented Aug 30, 2021

/run-e2e-tests

@STRRL
Copy link
Member

STRRL commented Aug 30, 2021

it seems Jenkins failed to pull e2e images:

[2021-08-30T11:29:34.705Z] [Normal][jenkins-tidb/chaos-mesh-e2e-942-kn1l0-htc76-n7m4q][BackOff] Back-off pulling image "hub.pingcap.net/yangkeao/chaos-mesh-e2e-base"

[2021-08-30T11:29:34.707Z] ERROR: Unable to pull Docker image "hub.pingcap.net/yangkeao/chaos-mesh-e2e-base". Check if image tag name is spelled correctly.

@cwen0
Copy link
Member

cwen0 commented Aug 31, 2021

/run-e2e-test

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@STRRL
Copy link
Member

STRRL commented Aug 31, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 291e856

@STRRL
Copy link
Member

STRRL commented Aug 31, 2021

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 7e71699 into chaos-mesh:release-2.0 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants