-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule-migration: fix dns scope && container name #2261
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #2261 +/- ##
===========================================
- Coverage 55.78% 40.69% -15.09%
===========================================
Files 68 127 +59
Lines 4383 8295 +3912
===========================================
+ Hits 2445 3376 +931
- Misses 1768 4588 +2820
- Partials 170 331 +161
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a334c2c
|
cherry pick to release-2.0 in PR #2288 |
Signed-off-by: xiang xiang13225080@163.com
What problem does this PR solve?
Issue Number: close #2256
Problem Summary:
containerName
is not deleted in spec, and thecontainerNames
is under a wrong place, below is an example:What is changed and how it works?
What's Changed:
scope
isall
, transform to pattern*
. Otherwise, exit with errorcontainerNames
Related changes
chaos-mesh/website
/chaos-mesh/website-zh
:Checklist
Tests
Side effects
Release note