chaos-daemon: fix nil pointer dereference in chaos-daemon #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
STRRL
reviewed
Sep 9, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…-daemon-panic-error
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: ff92d79
|
|
cherry pick to release-1.2 failed |
|
cherry pick to release-2.0 failed |
YangKeao
added a commit
to YangKeao/chaos-mesh
that referenced
this pull request
Oct 29, 2021
…#2289) * fix nil pointer dereference Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * change the variable name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove modification on unrelated files Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * run make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
YangKeao
added a commit
to YangKeao/chaos-mesh
that referenced
this pull request
Oct 29, 2021
…#2289) * fix nil pointer dereference Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * change the variable name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove modification on unrelated files Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * run make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Andrewmatilde
pushed a commit
that referenced
this pull request
Oct 29, 2021
) * fix nil pointer dereference Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * change the variable name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove modification on unrelated files Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * run make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added a commit
that referenced
this pull request
Oct 31, 2021
) * fix nil pointer dereference Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * change the variable name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove modification on unrelated files Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * run make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
When the
todaexited unexpectedly, the process will dereference annilerror.