easily to send HTTP request in task node #2308

STRRL · 2021-09-15T06:14:05Z

What problem does this PR solve?

Issue Number: It's a part of #2259

Problem Summary:

What is changed and how it works?

What's Changed:

Related changes

PR to update chaos-mesh/website/chaos-mesh/website-zh:
Need to update Chaos Dashboard component, related issue:
Need to cheery-pick to the release branch

Checklist

Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Side effects

Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

ti-chi-bot · 2021-09-15T06:14:06Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

g1eny0ung
iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: STRRL <str_ruiling@outlook.com>

pkg/curl/render.go

…orkflow-task

Signed-off-by: STRRL <str_ruiling@outlook.com>

…orkflow-task

Signed-off-by: STRRL <str_ruiling@outlook.com>

pkg/curl/parser.go

Signed-off-by: STRRL <str_ruiling@outlook.com>

Closes: chaos-mesh#2505 Signed-off-by: STRRL <str_ruiling@outlook.com>

iguoyr

LGTM

g1eny0ung · 2021-11-23T03:56:51Z

ui/src/i18n/en.json

      "deleteDesc": "This task will be deleted",
      "submitAll": "Submit All"
    },
    "serialTitle": "Set serial",
    "parallelTitle": "Set parallel",
    "suspendTitle": "Set suspend",
    "customTitle": "Set task",
+    "httpTitle": "Set HTTP Request",


Missed in zh.json.

done in 2ad163b

g1eny0ung · 2021-11-23T04:07:42Z

ui/src/components/NewWorkflow/HTTPTask.tsx

+    jsonContent: false,
+  })
+
+  const validateRequestForm = (newValue: RequestForm) => {


It looks like this validation is useless, I guess it can be removed?

done in 8efaaa0

g1eny0ung · 2021-11-23T04:11:34Z

ui/src/components/NewWorkflow/HTTPTask.tsx

+        .then((response) => {
+          if (response.data) {
+            const parsedForm = response.data as RequestForm
+            setInitialValues({


{ ...parsedForm, followLocation: parsedForm.followLocation || false, jsonContent: parsedForm.jsonContent || false, }

I think this block can be written like above if the fields are exact.

done in c86efdd

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL · 2021-11-23T08:02:52Z

Updated! PTAL @g1eny0ung

g1eny0ung

LGTM 🍺

g1eny0ung · 2021-11-23T08:10:20Z

/merge

ti-chi-bot · 2021-11-23T08:10:23Z

This pull request has been accepted and is ready to merge.

Commit hash: c86efdd

STRRL · 2021-11-23T14:52:24Z

/run-e2e-tests

STRRL · 2021-11-24T01:48:05Z

/run-e2e-tests

ti-chi-bot added the do-not-merge/work-in-progress label Sep 15, 2021

ti-chi-bot requested review from Colstuwjx and WangXiangUSTC September 15, 2021 06:14

ti-chi-bot added the size/XL label Sep 15, 2021

STRRL mentioned this pull request Sep 15, 2021

Workflow: easily to send HTTP reqeust in task node #2259

Closed

2 tasks

STRRL added 4 commits September 15, 2021 14:17

feat: basic implementation of curl render

a4b69d7

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: rename method name

d83d956

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: baisc parse

b3ee0e1

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: roundtrip tests

4b8b16d

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL force-pushed the http-request-on-workflow-task branch from 8e61e13 to 4b8b16d Compare September 15, 2021 06:17

Merge branch 'master' into http-request-on-workflow-task

516e14e

sonatype-lift bot reviewed Sep 15, 2021

View reviewed changes

pkg/curl/render.go Outdated Show resolved Hide resolved

STRRL added 2 commits September 22, 2021 12:43

Merge remote-tracking branch 'upstream/master' into http-request-on-w…

5edc5cd

…orkflow-task

feat: basic form for http request

bba5ad4

Signed-off-by: STRRL <str_ruiling@outlook.com>

ti-chi-bot added size/XXL and removed size/XL labels Sep 22, 2021

STRRL added 4 commits September 22, 2021 20:19

feat: api endpoint for http render and parse

51f896c

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: address the comments

58281c9

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: minor changes on API

e0c645a

Signed-off-by: STRRL <str_ruiling@outlook.com>

refactor: new component parallel and serial

d476b10

Signed-off-by: STRRL <str_ruiling@outlook.com>

ti-chi-bot added the needs-rebase label Oct 15, 2021

STRRL added 2 commits October 18, 2021 15:12

refactor: split Task into new component

a326ba6

Signed-off-by: STRRL <str_ruiling@outlook.com>

Merge remote-tracking branch 'upstream/master' into http-request-on-w…

845e9ca

…orkflow-task

ti-chi-bot removed the needs-rebase label Oct 18, 2021

STRRL added 5 commits October 20, 2021 00:46

chore: make check

0f68204

Signed-off-by: STRRL <str_ruiling@outlook.com>

feat: new HTTP API validate-task/http

068998f

Signed-off-by: STRRL <str_ruiling@outlook.com>

feat: update HTTPTask componnets

a91ac7e

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: update validation logic

d6cff4c

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: fix license checker

641e56b

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL changed the title ~~easily to send HTTP reqeust in task node~~ easily to send HTTP request in task node Nov 5, 2021

STRRL added 3 commits November 8, 2021 16:21

Merge branch 'master' into http-request-on-workflow-task

52dcb57

chore: cleanup useless fragment

90bb30d

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: cleanup otherType

1e982bd

Signed-off-by: STRRL <str_ruiling@outlook.com>

iguoyr reviewed Nov 9, 2021

View reviewed changes

pkg/curl/parser.go Outdated Show resolved Hide resolved

This was referenced Nov 10, 2021

workflow ui: duplicate names detected #2503

Open

workflow ui: unwanted content is auto-filled in task node #2504

Open

workflow ui: http request task does not need task number input-box #2505

Closed

workflow: config the value of curl image #2506

Open

chore: return some ignore error

3105f41

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL added this to the Release 2.1 milestone Nov 12, 2021

fix: reset children num with http request

c8ffc90

Closes: chaos-mesh#2505 Signed-off-by: STRRL <str_ruiling@outlook.com>

iguoyr approved these changes Nov 16, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Nov 16, 2021

cwen0 requested a review from g1eny0ung November 22, 2021 10:12

g1eny0ung reviewed Nov 23, 2021

View reviewed changes

STRRL added 3 commits November 23, 2021 15:57

chore: appending httpTitle in zh.json

2ad163b

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: remove unused variables

8efaaa0

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: udpate construction of setInitialValues for HTTPTask

c86efdd

Signed-off-by: STRRL <str_ruiling@outlook.com>

g1eny0ung approved these changes Nov 23, 2021

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Nov 23, 2021

ti-chi-bot added the status/can-merge label Nov 23, 2021

Merge branch 'master' into http-request-on-workflow-task

d21fe96

ti-chi-bot merged commit c43406e into chaos-mesh:master Nov 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

easily to send HTTP request in task node #2308

easily to send HTTP request in task node #2308

STRRL commented Sep 15, 2021 •

edited

Loading

ti-chi-bot commented Sep 15, 2021 •

edited

Loading

iguoyr left a comment

g1eny0ung Nov 23, 2021

STRRL Nov 23, 2021

g1eny0ung Nov 23, 2021

STRRL Nov 23, 2021

g1eny0ung Nov 23, 2021

STRRL Nov 23, 2021

STRRL commented Nov 23, 2021

g1eny0ung left a comment

g1eny0ung commented Nov 23, 2021

ti-chi-bot commented Nov 23, 2021

STRRL commented Nov 23, 2021

STRRL commented Nov 24, 2021

easily to send HTTP request in task node #2308

easily to send HTTP request in task node #2308

Conversation

STRRL commented Sep 15, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Checklist

Release note

ti-chi-bot commented Sep 15, 2021 • edited Loading

iguoyr left a comment

Choose a reason for hiding this comment

g1eny0ung Nov 23, 2021

Choose a reason for hiding this comment

STRRL Nov 23, 2021

Choose a reason for hiding this comment

g1eny0ung Nov 23, 2021

Choose a reason for hiding this comment

STRRL Nov 23, 2021

Choose a reason for hiding this comment

g1eny0ung Nov 23, 2021

Choose a reason for hiding this comment

STRRL Nov 23, 2021

Choose a reason for hiding this comment

STRRL commented Nov 23, 2021

g1eny0ung left a comment

Choose a reason for hiding this comment

g1eny0ung commented Nov 23, 2021

ti-chi-bot commented Nov 23, 2021

STRRL commented Nov 23, 2021

STRRL commented Nov 24, 2021

STRRL commented Sep 15, 2021 •

edited

Loading

ti-chi-bot commented Sep 15, 2021 •

edited

Loading