Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support aws/gcp chaos in dashboard archive #2338

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Sep 24, 2021

Signed-off-by: “fewdan” fewdan@hotmail.com

What problem does this PR solve?

support aws/gcp chaos in dashboard archive

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update chaos-mesh/website/chaos-mesh/website-zh:
  • Need to update Chaos Dashboard component, related issue:
  • Need to cheery-pick to the release branch

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

Signed-off-by: “fewdan” <fewdan@hotmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@08416a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2338   +/-   ##
==============================================
  Coverage               ?   43.15%           
==============================================
  Files                  ?      128           
  Lines                  ?     8854           
  Branches               ?        0           
==============================================
  Hits                   ?     3821           
  Misses                 ?     4704           
  Partials               ?      329           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08416a4...2097a95. Read the comment docs.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g1eny0ung
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2097a95

@ti-chi-bot ti-chi-bot merged commit 79f4d7d into chaos-mesh:release-2.0 Sep 24, 2021
@fewdan fewdan deleted the dashboard branch September 24, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants