Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stresschaos: don't add arguments to stress-ng if workers == 0 #2349

Merged
merged 2 commits into from
Sep 29, 2021
Merged

stresschaos: don't add arguments to stress-ng if workers == 0 #2349

merged 2 commits into from
Sep 29, 2021

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #2343

@YangKeao
don't add arguments to stress-ng if workers == 0
9ebad46 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

cwen0
cwen0 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fewdan
fewdan approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Sep 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ebad46

@ti-chi-bot ti-chi-bot merged commit 21eab8d into chaos-mesh:master Sep 29, 2021
@FingerLeader FingerLeader mentioned this pull request Oct 11, 2021
Closed
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #2369

ti-chi-bot pushed a commit that referenced this pull request Oct 11, 2021
@ti-srebot @YangKeao
stresschaos: don't add arguments to stress-ng if workers == 0 (#2349) (…
42b1914 
…#2369)

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fewdan fewdan fewdan approved these changes

@cwen0 cwen0 cwen0 approved these changes

@Yiyiyimu Yiyiyimu Awaiting requested review from Yiyiyimu

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating StressChaos on dashboard will cause unexpected arguments
5 participants
@YangKeao @ti-chi-bot @fewdan @ti-srebot @cwen0