Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support gcp authentication on UI #2363

Merged
merged 7 commits into from
Nov 23, 2021
Merged

feat: support gcp authentication on UI #2363

merged 7 commits into from
Nov 23, 2021

Conversation

g1eny0ung
Copy link
Member

What is changed and how it works?

Follow #2220.

What's Changed:

This PR allows Chaos Mesh to be managed via gcp authentication on the UI.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

@g1eny0ung
chore: init
478cc20 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung
chore: finish
9b8ee3b 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@g1eny0ung g1eny0ung changed the title feat: add gcp authentication ui feat: support gcp authentication on UI Oct 8, 2021
@g1eny0ung g1eny0ung requested a review from cwen0 October 9, 2021 06:40
@g1eny0ung
fix: add license header
15a2350 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung
Merge branch 'master' into chore/gcp-ui
ebddfed
@g1eny0ung
chore: whether to hide gcp login by config
7da6226 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@g1eny0ung g1eny0ung marked this pull request as ready for review November 10, 2021 06:26
@g1eny0ung g1eny0ung requested review from YangKeao and removed request for WangXiangUSTC and yeya24 November 10, 2021 06:26
@g1eny0ung g1eny0ung added this to the Release 2.1 milestone Nov 10, 2021
@g1eny0ung g1eny0ung added this to In progress in Project Kanban via automation Nov 10, 2021
YangKeao
YangKeao approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g1eny0ung g1eny0ung mentioned this pull request Nov 22, 2021
Merged
cwen0
cwen0 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Nov 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ecf8c6c

@ti-chi-bot ti-chi-bot merged commit 61359c8 into chaos-mesh:master Nov 23, 2021
Project Kanban automation moved this from In progress to Done Nov 23, 2021
@g1eny0ung g1eny0ung deleted the chore/gcp-ui branch November 23, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@cwen0 cwen0 cwen0 approved these changes

Assignees
No one assigned
Labels
component/ui size/XXL status/can-merge status/LGT2
Projects
Project Kanban
Done
Milestone
Release 2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g1eny0ung @ti-chi-bot @cwen0 @YangKeao