-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix finalizers outdated bug on two phase conflict #2430
fix finalizers outdated bug on two phase conflict #2430
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
776a42a
to
88d4a3a
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.2 #2430 +/- ##
==============================================
Coverage ? 50.84%
==============================================
Files ? 86
Lines ? 6363
Branches ? 0
==============================================
Hits ? 3235
Misses ? 2832
Partials ? 296 Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 88d4a3a
|
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi <i@hexilee.me>
Signed-off-by: xixi i@hexilee.me
What problem does this PR solve?
Problem Summary:
In current release-1.2 branch, finalizers won't be updated on conflict.
What is changed and how it works?
What's Changed:
Update finalizers in
RetryOnConflict
.Related changes
Checklist
Tests
Side effects
Release note