Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update admissionregistration with v1 #2441

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Nov 1, 2021

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

Issue Number:

Problem Summary:

  • helm charts on release-2.0 still using admissionregistartion v1beat1, which has been removed from kubernetes 1.22, so 2.0.x could not play well with k8s 1.22+

What is changed and how it works?

What's Changed:

  • update helm charts

Related changes

  • PR to update chaos-mesh/website/chaos-mesh/website-zh: No.
  • Need to update Chaos Dashboard component, related issue: No.
  • Need to cheery-pick to the release branch: No.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: STRRL <str_ruiling@outlook.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@9a70107). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d81732d differs from pull request most recent head 11956dc. Consider uploading reports for the commit 11956dc to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2441   +/-   ##
==============================================
  Coverage               ?   42.77%           
==============================================
  Files                  ?      128           
  Lines                  ?     8861           
  Branches               ?        0           
==============================================
  Hits                   ?     3790           
  Misses                 ?     4743           
  Partials               ?      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a70107...11956dc. Read the comment docs.

Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Nov 1, 2021
@STRRL
Copy link
Member Author

STRRL commented Nov 2, 2021

PTAL
/cc @WangXiangUSTC
/cc @YangKeao

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

YangKeao commented Nov 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71971bf

@ti-chi-bot ti-chi-bot merged commit 52d2bf2 into chaos-mesh:release-2.0 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants