Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: use updatedClient to fix cache problem #2534

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 17, 2021

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

After #2509 , the cache in client breaks the twophase controller:

  1. The controller updates the chaos into Running.
  2. The controller reconciles the chaos, gets a cache and think it's waiting
  3. Step into the finished state, merge the conflict, remove the finalizer and step out.

In this PR, I backported the UpdatedClient in release-2.0 to make the cache at least updated to the latest successfully Updated object.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Hexilee
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@16ef2c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.2    #2534   +/-   ##
==============================================
  Coverage               ?   50.83%           
==============================================
  Files                  ?       86           
  Lines                  ?     6362           
  Branches               ?        0           
==============================================
  Hits                   ?     3234           
  Misses                 ?     2832           
  Partials               ?      296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ef2c7...81a5f2a. Read the comment docs.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Nov 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 81a5f2a

@ti-chi-bot ti-chi-bot merged commit f0adeb5 into chaos-mesh:release-1.2 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants