-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: use updatedClient to fix cache problem #2534
client: use updatedClient to fix cache problem #2534
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-1.2 #2534 +/- ##
==============================================
Coverage ? 50.83%
==============================================
Files ? 86
Lines ? 6362
Branches ? 0
==============================================
Hits ? 3234
Misses ? 2832
Partials ? 296 Continue to review full report at Codecov.
|
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 81a5f2a
|
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
After #2509 , the cache in client breaks the twophase controller:
In this PR, I backported the
UpdatedClient
inrelease-2.0
to make the cache at least updated to the latest successfullyUpdate
d object.