Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in NewExperiment screen #2535

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Fix typo in NewExperiment screen #2535

merged 2 commits into from
Dec 9, 2021

Conversation

xbx
Copy link
Contributor

@xbx xbx commented Nov 17, 2021 •
edited by g1eny0ung
Loading

What problem does this PR solve?

Problem Summary:

Just a typo.

What's changed and how it works?

What's Changed:

Related changes

  • Need to update chaos-mesh/website
  • Need to update Chaos Dashboard
  • Need to cheery-pick to release branches

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @xbx!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

@STRRL
Copy link
Member

STRRL commented Nov 17, 2021

Hi @xbx , thanks for your contribution!

Please fix the DCO first, you could inspect the detail by clicking the failed DCO check. :D

g1eny0ung
g1eny0ung approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@cwen0
Copy link
Member

cwen0 commented Nov 24, 2021

@xbx Can you fix the DCO first?

YangKeao
YangKeao approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xbx @STRRL
Fix typo in NewExperiment screen
839732a 
Signed-off-by: Roberto Bravo <xbx.roberto@gmail.com>
@STRRL
Copy link
Member

STRRL commented Dec 9, 2021

Hi @xbx, I make an update on your branch and fix the DCO issue because you enable the Allow edits and access to secrets by maintainers. Thanks for your contribution!

@STRRL
Copy link
Member

STRRL commented Dec 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 839732a

@ti-chi-bot ti-chi-bot merged commit d0a24c1 into chaos-mesh:master Dec 9, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot ti-srebot mentioned this pull request Dec 9, 2021
Merged
8 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2620

ti-chi-bot pushed a commit that referenced this pull request Dec 9, 2021
@ti-srebot @xbx
Fix typo in NewExperiment screen (#2535) (#2620)
bc020e8 
Signed-off-by: Roberto Bravo <xbx.roberto@gmail.com>

Co-authored-by: Roberto Bravo <xbx.roberto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@g1eny0ung g1eny0ung g1eny0ung approved these changes

@Yiyiyimu Yiyiyimu Awaiting requested review from Yiyiyimu

Assignees
No one assigned
Labels
contribution first-time-contributor needs-cherry-pick-release-2.0 needs-cherry-pick-release-2.1 size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xbx @ti-chi-bot @STRRL @cwen0 @ti-srebot @YangKeao @g1eny0ung