Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): allow docker client use low version API (#2544) #2546

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 22, 2021

cherry-pick #2544 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/2546

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/2546:release-2.0-e7bacc1f093a

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Close #2413

This PR makes the docker client can receive env variables to set the version of the API to reach.

What's changed and how it works?

Add client.FromEnv to ops.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Chaos Dashboard
  • Need to cheery-pick to release branches

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

steps:

  1. Downgrade docker to 18.09 and build the local images.
  2. Install: helm install chaos-mesh helm/chaos-mesh -n=chaos-testing --set images.registry=localhost:5000,dashboard.securityMode=false,dashboard.image.repository=g1eny0ung/chaos-dashboard,chaosDaemon.image.repository=g1eny0ung/chaos-daemon,controllerManager.image.repository=g1eny0ung/chaos-mesh,chaosDaemon.env.DOCKER_API_VERSION=1.39
  3. Test with a network-delay experiment
  4. Successfully injected.

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@3f1f543). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2546   +/-   ##
==============================================
  Coverage               ?   42.75%           
==============================================
  Files                  ?      128           
  Lines                  ?     8878           
  Branches               ?        0           
==============================================
  Hits                   ?     3796           
  Misses                 ?     4752           
  Partials               ?      330           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1f543...2cbe8fe. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cbe8fe

@STRRL
Copy link
Member

STRRL commented Nov 22, 2021

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 97ab36d into chaos-mesh:release-2.0 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants