-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(daemon): allow docker client use low version API (#2544) #2546
fix(daemon): allow docker client use low version API (#2544) #2546
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-2.0 #2546 +/- ##
==============================================
Coverage ? 42.75%
==============================================
Files ? 128
Lines ? 8878
Branches ? 0
==============================================
Hits ? 3796
Misses ? 4752
Partials ? 330 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2cbe8fe
|
/run-e2e-tests |
cherry-pick #2544 to release-2.0
You can switch your code base to this Pull Request by using git-extras:
# In chaos-mesh repo: git pr https://github.com/chaos-mesh/chaos-mesh/pull/2546
After apply modifications, you can push your change to this PR via:
Signed-off-by: Yue Yang g1enyy0ung@gmail.com
What problem does this PR solve?
Close #2413
This PR makes the docker client can receive env variables to set the version of the API to reach.
What's changed and how it works?
Add
client.FromEnv
to ops.Related changes
chaos-mesh/website
Chaos Dashboard
Checklist
Tests
18.09
and build the local images.helm install chaos-mesh helm/chaos-mesh -n=chaos-testing --set images.registry=localhost:5000,dashboard.securityMode=false,dashboard.image.repository=g1eny0ung/chaos-dashboard,chaosDaemon.image.repository=g1eny0ung/chaos-daemon,controllerManager.image.repository=g1eny0ung/chaos-mesh,chaosDaemon.env.DOCKER_API_VERSION=1.39
network-delay
experimentSide effects
Release note