Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't load schedule archives (#2524) #2563

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Problem Summary:

What's changed and how it works?

What's Changed:

Related changes

  • Need to update chaos-mesh/website
  • Need to update Chaos Dashboard
  • Need to cheery-pick to release branches

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@75369f2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2563   +/-   ##
==============================================
  Coverage               ?   42.86%           
==============================================
  Files                  ?      128           
  Lines                  ?     8879           
  Branches               ?        0           
==============================================
  Hits                   ?     3806           
  Misses                 ?     4744           
  Partials               ?      329           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75369f2...cf74978. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Nov 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cf74978

@STRRL
Copy link
Member

STRRL commented Nov 25, 2021

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 96f50b1 into chaos-mesh:release-2.0 Nov 25, 2021
@g1eny0ung g1eny0ung deleted the cherry-pick-2524 branch November 29, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants