Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm install error #2591

Merged
merged 2 commits into from
Dec 2, 2021
Merged

fix: helm install error #2591

merged 2 commits into from
Dec 2, 2021

Conversation

kxzonly
Copy link
Contributor

@kxzonly kxzonly commented Dec 2, 2021 •
edited by g1eny0ung
Loading

What problem does this PR solve?

Close #2589

Problem Summary:

What's changed and how it works?

What's Changed:

helm/chaos-mesh/templates/chaos-dashboard-pvc.yaml

Related changes

  • Need to update chaos-mesh/website
  • Need to update Chaos Dashboard
  • Need to cheery-pick to release branches

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note 

fix issue #2589 and changed files: helm/chaos-mesh/templates/chaos-dashboard-pvc.yaml

fix issue 2589 helm install error（when i use pvcs，it occured）
cd1f6e4 
changed files:
helm/chaos-mesh/templates/chaos-dashboard-pvc.yaml

Signed-off-by: root <root@localhost.localdomain>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @kxzonly!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

@kxzonly kxzonly mentioned this pull request Dec 2, 2021
Closed
@cwen0 cwen0 linked an issue Dec 2, 2021 that may be closed by this pull request
helm install error（when i use pvcs，it occured） #2589
Closed
@kxzonly
fix some generate go file
72c3ce9 
Signed-off-by: kxz_only <kxz@kxzonly.cn>
@ti-chi-bot ti-chi-bot added size/XS and removed size/S labels Dec 2, 2021
@kxzonly kxzonly requested a review from cwen0 December 2, 2021 08:00
cwen0
cwen0 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Dec 2, 2021

/merge

STRRL
STRRL approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72c3ce9

@g1eny0ung g1eny0ung changed the title fix: issue #2589 helm install error（when i use pvcs，it occured） fix: helm install error Dec 2, 2021
@ti-chi-bot ti-chi-bot merged commit 4caa377 into chaos-mesh:master Dec 2, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot ti-srebot mentioned this pull request Dec 2, 2021
Merged
8 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2592

@STRRL
Copy link
Member

STRRL commented Dec 2, 2021

cherry pick to release-2.0 failed

We do not apply skywalking license checker and license boilerplate on branch release-2.0, so we do not cherry-pick it on release-2.0. I am going to remove this tag.

ti-chi-bot pushed a commit that referenced this pull request Dec 2, 2021
@ti-srebot @kxzonly
fix: helm install error (#2591) (#2592)
fcc7512 
* fix issue 2589 helm install error（when i use pvcs，it occured） changed files: helm/chaos-mesh/templates/chaos-dashboard-pvc.yaml

Signed-off-by: root <root@localhost.localdomain>

* fix some generate go file

Signed-off-by: kxz_only <kxz@kxzonly.cn>

Co-authored-by: root <root@localhost.localdomain>
Co-authored-by: kxz_only <kxz@kxzonly.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1eny0ung g1eny0ung g1eny0ung approved these changes

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 cwen0 approved these changes

@Gallardot Gallardot Awaiting requested review from Gallardot

@yeya24 yeya24 Awaiting requested review from yeya24

Assignees
No one assigned
Labels
contribution first-time-contributor needs-cherry-pick-release-2.1 size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm install error（when i use pvcs，it occured）
6 participants
@kxzonly @ti-chi-bot @cwen0 @ti-srebot @STRRL @g1eny0ung