Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nil check when creating stressor #2655

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Dec 16, 2021

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

close #2654

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@a2d2762). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2655   +/-   ##
==============================================
  Coverage               ?   42.85%           
==============================================
  Files                  ?      128           
  Lines                  ?     8882           
  Branches               ?        0           
==============================================
  Hits                   ?     3806           
  Misses                 ?     4745           
  Partials               ?      331           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d2762...a2bcd4a. Read the comment docs.

@STRRL STRRL marked this pull request as ready for review December 17, 2021 03:21
@STRRL STRRL added the type/bug-fix A bug needs to be fixed. label Dec 17, 2021
@STRRL STRRL marked this pull request as draft December 17, 2021 03:23
@STRRL STRRL marked this pull request as ready for review December 20, 2021 08:37
@STRRL
Copy link
Member Author

STRRL commented Dec 21, 2021

PTAL

/cc @chaos-mesh/committers @chaos-mesh/maintainers

@ti-chi-bot ti-chi-bot requested review from a team December 21, 2021 03:26
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 14cd144

@STRRL
Copy link
Member Author

STRRL commented Dec 21, 2021

/run-e2e-tests

1 similar comment
@STRRL
Copy link
Member Author

STRRL commented Dec 21, 2021

/run-e2e-tests

@STRRL
Copy link
Member Author

STRRL commented Dec 22, 2021

/run-e2e-tests

:(

@STRRL
Copy link
Member Author

STRRL commented Dec 23, 2021

/run-e2e-tests

@STRRL
Copy link
Member Author

STRRL commented Dec 23, 2021

/merge

@ti-chi-bot
Copy link
Member

@STRRL: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@STRRL
Copy link
Member Author

STRRL commented Dec 23, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit a44d8af into chaos-mesh:release-2.0 Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants