Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #2679, #2706 and #2714 to release 2.0 #2694

Merged
merged 7 commits into from
Jan 6, 2022
Merged

Cherry pick #2679, #2706 and #2714 to release 2.0 #2694

merged 7 commits into from
Jan 6, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Dec 22, 2021 •
edited

What problem does this PR solve?

What's changed and how it works?

Manually cherry-pick #2679, #2706 and #2714 to release-2.0

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@STRRL @ti-chi-bot
feat: new ci for upload coverage data to codecov (chaos-mesh#2679)
d276019 
* feat: new ci for upload coverage data to codecov

Signed-off-by: STRRL <str_ruiling@outlook.com>

* test: do not push code coverage wihtin ci.yml

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update coverage drop threshold

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update for lincense checker

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: not specify a certain ref with action/checkout

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Dec 27, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@312a648). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2694   +/-   ##
==============================================
  Coverage               ?   42.10%           
==============================================
  Files                  ?      127           
  Lines                  ?    10868           
  Branches               ?        0           
==============================================
  Hits                   ?     4576           
  Misses                 ?     5964           
  Partials               ?      328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312a648...111cb10. Read the comment docs.

@STRRL STRRL mentioned this pull request Dec 27, 2021
Merged
9 tasks
@STRRL @ti-chi-bot
chore: disable codecov/patch (chaos-mesh#2714)
8849c7b 
Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL changed the title Cherry pick #2679 to release 2.0 Cherry pick #2679 and #2714 to release 2.0 Dec 27, 2021
@STRRL @ti-chi-bot
chore: use -covermode atomic for accuracy hits with parallel (chaos…
271ced0 
…-mesh#2706)

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL changed the title Cherry pick #2679 and #2714 to release 2.0 Cherry pick #2679, #2706 and #2714 to release 2.0 Jan 5, 2022
@STRRL STRRL marked this pull request as ready for review January 5, 2022 06:13
@STRRL
Copy link
Member Author

STRRL commented Jan 5, 2022

PTAL

/cc @chaos-mesh/committers @chaos-mesh/maintainers

@ti-chi-bot ti-chi-bot requested review from a team January 5, 2022 06:14
cwen0
cwen0 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YangKeao
YangKeao approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

YangKeao commented Jan 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 111cb10

@STRRL
Copy link
Member Author

STRRL commented Jan 6, 2022

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 6b66e33 into chaos-mesh:release-2.0 Jan 6, 2022
@STRRL STRRL deleted the cherry-pick-2679-to-release-2.0 branch January 7, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@cwen0 cwen0 cwen0 approved these changes

@Andrewmatilde Andrewmatilde Awaiting requested review from Andrewmatilde

@AsterNighT AsterNighT Awaiting requested review from AsterNighT

Assignees
No one assigned
Labels
size/M status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@STRRL @ti-chi-bot @YangKeao @cwen0