Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVMChaos: ignore AgentLoadException when install agent #2701

Merged
merged 5 commits into from
Jan 12, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Dec 23, 2021

Signed-off-by: xiang xiang13225080@163.com

What problem does this PR solve?

fix issue #2690

What's changed and how it works?

install com.sun.tools.attach.AgentLoadException: 0 this error is caused by the different attach result codes in different java versions. In fact, the agent has attached success, just ignore it here.

refer to https://stackoverflow.com/questions/54340438/virtualmachine-attach-throws-com-sun-tools-attach-agentloadexception-0-when-usi/54454418#54454418

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xiang <xiang13225080@163.com>
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #2701 (b8fefb4) into master (857bcc7) will increase coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2701      +/-   ##
==========================================
+ Coverage   40.90%   41.21%   +0.30%     
==========================================
  Files         144      144              
  Lines       11738    11742       +4     
==========================================
+ Hits         4802     4840      +38     
+ Misses       6572     6544      -28     
+ Partials      364      358       -6     
Impacted Files Coverage Δ
pkg/chaosdaemon/jvm_server.go 0.00% <0.00%> (ø)
pkg/workflow/controllers/utils.go 85.71% <0.00%> (-1.59%) ⬇️
pkg/workflow/controllers/task_reconciler.go 6.73% <0.00%> (+0.80%) ⬆️
pkg/workflow/controllers/serial_node_reconciler.go 60.73% <0.00%> (+1.57%) ⬆️
...g/workflow/controllers/parallel_node_reconciler.go 63.46% <0.00%> (+1.92%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 61.31% <0.00%> (+3.15%) ⬆️
pkg/workflow/controllers/deadline_reconciler.go 69.62% <0.00%> (+5.18%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (+6.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857bcc7...b8fefb4. Read the comment docs.

@WangXiangUSTC WangXiangUSTC requested review from Andrewmatilde and STRRL and removed request for Colstuwjx and Hexilee December 28, 2021 03:50
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrewmatilde
Copy link
Member

PTAL, @STRRL .

@STRRL
Copy link
Member

STRRL commented Jan 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d389add

@STRRL
Copy link
Member

STRRL commented Jan 12, 2022

Should we cherry-pick this PR to release-2.0 and release-2.1? @WangXiangUSTC

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2787

@WangXiangUSTC
Copy link
Contributor Author

Should we cherry-pick this PR to release-2.0 and release-2.1? @WangXiangUSTC

need to cherry-pick to 2.1

ti-chi-bot added a commit that referenced this pull request Jan 16, 2022
* ignore AgentLoadException when install agent

Signed-off-by: xiang <xiang13225080@163.com>

* update comment

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: xiang <xiang13225080@163.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants