-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JVMChaos: ignore AgentLoadException when install agent #2701
JVMChaos: ignore AgentLoadException when install agent #2701
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: xiang <xiang13225080@163.com>
Codecov Report
@@ Coverage Diff @@
## master #2701 +/- ##
==========================================
+ Coverage 40.90% 41.21% +0.30%
==========================================
Files 144 144
Lines 11738 11742 +4
==========================================
+ Hits 4802 4840 +38
+ Misses 6572 6544 -28
+ Partials 364 358 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL, @STRRL . |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d389add
|
Should we cherry-pick this PR to |
cherry pick to release-2.1 in PR #2787 |
need to cherry-pick to 2.1 |
* ignore AgentLoadException when install agent Signed-off-by: xiang <xiang13225080@163.com> * update comment Signed-off-by: xiang <xiang13225080@163.com> Co-authored-by: xiang <xiang13225080@163.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: xiang xiang13225080@163.com
What problem does this PR solve?
fix issue #2690
What's changed and how it works?
install com.sun.tools.attach.AgentLoadException: 0
this error is caused by the different attach result codes in different java versions. In fact, the agent has attached success, just ignore it here.refer to https://stackoverflow.com/questions/54340438/virtualmachine-attach-throws-com-sun-tools-attach-agentloadexception-0-when-usi/54454418#54454418
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note