feat(chaos dashboard): add deleting status #2708

cwen0 · 2021-12-23T10:51:53Z

What problem does this PR solve?

What's changed and how it works?

If the chaos object is deleted and blocked, we should show it on chaos dashboard. In this pr, I add a new status deleting to describe this status.

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.1
- release-2.0

Checklist

Tests

Unit test
E2E test
No code
Manual test (add steps below)

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: cwen0 <cwenyin0@gmail.com>

ti-chi-bot · 2021-12-23T10:51:54Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL
g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2021-12-23T11:03:11Z

Codecov Report

Merging #2708 (7012573) into master (8cdbeac) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
+ Coverage   41.08%   41.10%   +0.01%     
==========================================
  Files         144      144              
  Lines       11719    11719              
==========================================
+ Hits         4815     4817       +2     
- Misses       6541     6542       +1     
+ Partials      363      360       -3

Impacted Files	Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go	`48.14% <0.00%> (-4.77%)`	⬇️
pkg/selector/generic/mode.go	`25.64% <0.00%> (-2.57%)`	⬇️
pkg/workflow/controllers/task_reconciler.go	`6.73% <0.00%> (+0.80%)`	⬆️
pkg/workflow/controllers/serial_node_reconciler.go	`60.73% <0.00%> (+1.57%)`	⬆️
pkg/workflow/controllers/deadline_reconciler.go	`69.62% <0.00%> (+5.18%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cdbeac...7012573. Read the comment docs.

Signed-off-by: cwen0 <cwenyin0@gmail.com>

g1eny0ung · 2021-12-28T03:09:17Z

The name Deleted is more accurate?

cwen0 · 2021-12-28T03:30:43Z

The name Deleted is more accurate?

I don't think so. Because the real status is deleting and the chaos experiment has not been recovered. Deleted maybe make users confused.

g1eny0ung · 2021-12-28T03:40:05Z

The name Deleted is more accurate?

I don't think so. Because the real status is deleting and the chaos experiment has not been recovered. Deleted maybe make users confused.

But according to my understanding, when users click on the Deleting experiment, API will return experiment not found, it's also weird. 😢

cwen0 · 2021-12-28T04:40:50Z

The name Deleted is more accurate?

I don't think so. Because the real status is deleting and the chaos experiment has not been recovered. Deleted maybe make users confused.

But according to my understanding, when users click on the Deleting experiment, API will return experiment not found, it's also weird. 😢

This issue was fixed in #2698

g1eny0ung

Know about it. This LGTM. 👍🏽

STRRL

LGTM

STRRL · 2022-01-05T06:03:32Z

/merge

ti-chi-bot · 2022-01-05T06:03:34Z

This pull request has been accepted and is ready to merge.

Commit hash: 4c0f79e

STRRL · 2022-01-06T05:32:37Z

/merge

cwen0 · 2022-01-06T07:44:29Z

/run-e2e-tests

ti-srebot · 2022-01-06T08:30:54Z

cherry pick to release-2.0 failed

ti-srebot · 2022-01-06T08:31:08Z

cherry pick to release-2.1 in PR #2753

* feat: add deleting status Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix ci Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: cwen0 <cwenyin0@gmail.com>

* feat: add deleting status Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix ci Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Craig Seeman <cseeman@zendesk.com>

Signed-off-by: cwen0 <cwenyin0@gmail.com>

…-mesh#2708 Signed-off-by: STRRL <str_ruiling@outlook.com>

Signed-off-by: STRRL <str_ruiling@outlook.com>

…-mesh#2708 (chaos-mesh#2827) Signed-off-by: STRRL <str_ruiling@outlook.com>

* time: add fake image for vdso gettimeofday (#2742) * Add: the fake image for vdso gettimeofday Signed-off-by: reigending <1066297896@qq.com> * update: namethings and struct of time skew Signed-off-by: reigending <1066297896@qq.com> * Fix: name things Signed-off-by: reigending <1066297896@qq.com> * Update: CHANGELOG.md add section Signed-off-by: reigending <1066297896@qq.com> * Fix: camelCase naming mistake Signed-off-by: reigending <1066297896@qq.com> Co-authored-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: STRRL <str_ruiling@outlook.com> * refactor: move common used attach/ptrace function (#2675) * refactor: move common used attach/ptrace function Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make check Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: replace refactored method in SkewClockGetTime Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: apply refactored methods to other FakeClockInjector Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: append changelog for #2753, cherry-picked from #2708 (#2827) Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: fix makefile Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Reigen <37658394+ReigenDing@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

feat: add deleting status

6692a4f

Signed-off-by: cwen0 <cwenyin0@gmail.com>

cwen0 added component/dashboard needs-cherry-pick-release-2.0 needs-cherry-pick-release-2.1 labels Dec 23, 2021

ti-chi-bot requested review from Andrewmatilde and WangXiangUSTC December 23, 2021 10:52

ti-chi-bot added the size/S label Dec 23, 2021

fix ci

4c0f79e

Signed-off-by: cwen0 <cwenyin0@gmail.com>

g1eny0ung approved these changes Dec 28, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Dec 28, 2021

STRRL approved these changes Jan 5, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Jan 5, 2022

ti-chi-bot added the status/can-merge label Jan 5, 2022

Merge branch 'master' into add-deleting-status

7012573

chaos-mesh deleted a comment from STRRL Jan 6, 2022

ti-chi-bot merged commit 0528b02 into chaos-mesh:master Jan 6, 2022

ti-srebot mentioned this pull request Jan 6, 2022

feat(chaos dashboard): add deleting status (#2708) #2753

Merged

9 tasks

cwen0 deleted the add-deleting-status branch January 6, 2022 11:20

cwen0 mentioned this pull request Jan 6, 2022

feat: add deleting status (cherry-pick #2708) #2756

Merged

9 tasks

ti-chi-bot pushed a commit that referenced this pull request Jan 11, 2022

feat: add deleting status (cherry-pick #2708) (#2756)

7516d68

Signed-off-by: cwen0 <cwenyin0@gmail.com>

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Jan 25, 2022

chore: append changelog for chaos-mesh#2753, cherry-picked from chaos…

ad6285e

…-mesh#2708 Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Jan 25, 2022

chore: append changelog for chaos-mesh#2753, cherry-picked from chaos…

f28ccc3

…-mesh#2708 Signed-off-by: STRRL <str_ruiling@outlook.com>

ti-chi-bot pushed a commit that referenced this pull request Jan 26, 2022

chore: append changelog for #2753, cherry-picked from #2708 (#2827)

d1eda75

Signed-off-by: STRRL <str_ruiling@outlook.com>

STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Jan 26, 2022

chore: append changelog for chaos-mesh#2753, cherry-picked from chaos…

8271809

…-mesh#2708 (chaos-mesh#2827) Signed-off-by: STRRL <str_ruiling@outlook.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(chaos dashboard): add deleting status #2708

feat(chaos dashboard): add deleting status #2708

cwen0 commented Dec 23, 2021 •

edited

ti-chi-bot commented Dec 23, 2021 •

edited

codecov bot commented Dec 23, 2021 •

edited

g1eny0ung commented Dec 28, 2021

cwen0 commented Dec 28, 2021

g1eny0ung commented Dec 28, 2021 •

edited

cwen0 commented Dec 28, 2021

g1eny0ung left a comment

STRRL left a comment

STRRL commented Jan 5, 2022

ti-chi-bot commented Jan 5, 2022

STRRL commented Jan 6, 2022

cwen0 commented Jan 6, 2022

ti-srebot commented Jan 6, 2022

ti-srebot commented Jan 6, 2022

feat(chaos dashboard): add deleting status #2708

feat(chaos dashboard): add deleting status #2708

Conversation

cwen0 commented Dec 23, 2021 • edited

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Dec 23, 2021 • edited

codecov bot commented Dec 23, 2021 • edited

Codecov Report

g1eny0ung commented Dec 28, 2021

cwen0 commented Dec 28, 2021

g1eny0ung commented Dec 28, 2021 • edited

cwen0 commented Dec 28, 2021

g1eny0ung left a comment

Choose a reason for hiding this comment

STRRL left a comment

Choose a reason for hiding this comment

STRRL commented Jan 5, 2022

ti-chi-bot commented Jan 5, 2022

STRRL commented Jan 6, 2022

cwen0 commented Jan 6, 2022

ti-srebot commented Jan 6, 2022

ti-srebot commented Jan 6, 2022

cwen0 commented Dec 23, 2021 •

edited

ti-chi-bot commented Dec 23, 2021 •

edited

codecov bot commented Dec 23, 2021 •

edited

g1eny0ung commented Dec 28, 2021 •

edited