blockchaos: api definition and selector implementation #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Codecov Report
@@ Coverage Diff @@
## master #2739 +/- ##
==========================================
+ Coverage 41.03% 41.07% +0.04%
==========================================
Files 144 146 +2
Lines 11747 11868 +121
==========================================
+ Hits 4820 4875 +55
- Misses 6565 6627 +62
- Partials 362 366 +4
Continue to review full report at Codecov.
|
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
|
@g1eny0ung This PR also modifies the dashboard (as the CI won't pass, if I don't implement the dashboard). PTAL |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 49f2393
|
rksharma95
pushed a commit
to rksharma95/chaos-mesh
that referenced
this pull request
Jan 26, 2022
* add basic type for blockchaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * bootstrap blockchaos and nodevolumepath selector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * generate files from blockchaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add licenses for examples Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * group the imports Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * register an unknown blockchaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * try to add dashboard for blockchaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add webhook Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * regenerate yaml files Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * frontend implementation of blockchaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: rksharma95 <nikhilrk13jan@gmail.com>
STRRL
added a commit
to STRRL/chaos-mesh
that referenced
this pull request
Apr 29, 2022
…-mesh#2739)" This reverts commit 618a4cb.
STRRL
added a commit
to STRRL/chaos-mesh
that referenced
this pull request
Apr 29, 2022
…-mesh#2739)" This reverts commit 618a4cb.
STRRL
added a commit
to STRRL/chaos-mesh
that referenced
this pull request
Apr 29, 2022
…-mesh#2739)" This reverts commit 618a4cb. Signed-off-by: STRRL <im@strrl.dev>
ti-chi-bot
added a commit
that referenced
this pull request
Apr 29, 2022
* Revert "blockchaos: api definition and selector implementation (#2739)" This reverts commit 618a4cb. Signed-off-by: STRRL <im@strrl.dev> * chore: revert changes on frontend Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> * restore yarn cache Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
According to the chaos-mesh/rfcs#29 , the
BlockChaosAPI definition and the volume path selector implementation is here 😺 .What's changed and how it works?
chaos-mesh/rfcs#29
Document issue: #2738