Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version of toda to v0.2.2 #2747

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 4, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

Fix #2626, #2688

What problem does this PR solve?

This PR solves two problem:

  1. The cwd_replacer works correctly now.
  2. Long latency will block the toda from recovery. It's because the processes are still waiting inside the latency. This PR makes the latency cancellable, and will interrupt the sleeping when it tries to resume.

What's changed and how it works?

For the first problem, the cwd_replacer doesn't consider the situation when the process were inside the subdirectory of volume. It changes the cwd of processes into the root of the volume, which is not expected. The fix is quite simple, you can read the chaos-mesh/toda@7ca342b .

For the second problem, you can read chaos-mesh/toda@65071a4 .

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Hexilee
  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #2747 (32bb354) into master (762dc73) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 32bb354 differs from pull request most recent head c51d32d. Consider uploading reports for the commit c51d32d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
- Coverage   41.03%   40.97%   -0.06%     
==========================================
  Files         144      144              
  Lines       11719    11719              
==========================================
- Hits         4809     4802       -7     
- Misses       6548     6553       +5     
- Partials      362      364       +2     
Impacted Files Coverage Δ
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
api/v1alpha1/zz_generated.chaosmesh.go 57.26% <0.00%> (-0.37%) ⬇️
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 48.14% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9779b...c51d32d. Read the comment docs.

@YangKeao YangKeao requested review from Hexilee and a team January 4, 2022 11:52
@YangKeao YangKeao linked an issue Jan 4, 2022 that may be closed by this pull request
@YangKeao
Copy link
Member Author

YangKeao commented Jan 4, 2022

/run-e2e-tests

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao changed the title bump version of toda to v0.2.1 bump version of toda to v0.2.2 Jan 6, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Jan 6, 2022

/run-e2e-tests

@YangKeao
Copy link
Member Author

YangKeao commented Jan 6, 2022

/run-e2e-tests

Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Jan 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 32bb354

@ti-chi-bot ti-chi-bot merged commit eabc261 into chaos-mesh:master Jan 10, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2764

craig-seeman pushed a commit to craig-seeman/chaos-mesh that referenced this pull request Jan 10, 2022
* bump version of toda to v0.2.1

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* bump toda version to 0.2.2

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Craig Seeman <cseeman@zendesk.com>
ti-chi-bot added a commit that referenced this pull request Jan 11, 2022
* bump version of toda to v0.2.1

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* bump toda version to 0.2.2

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants