-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version of toda to v0.2.2 #2747
bump version of toda to v0.2.2 #2747
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #2747 +/- ##
==========================================
- Coverage 41.03% 40.97% -0.06%
==========================================
Files 144 144
Lines 11719 11719
==========================================
- Hits 4809 4802 -7
- Misses 6548 6553 +5
- Partials 362 364 +2
Continue to review full report at Codecov.
|
/run-e2e-tests |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
/run-e2e-tests |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 32bb354
|
cherry pick to release-2.0 failed |
cherry pick to release-2.1 in PR #2764 |
* bump version of toda to v0.2.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * bump toda version to 0.2.2 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Craig Seeman <cseeman@zendesk.com>
* bump version of toda to v0.2.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * bump toda version to 0.2.2 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: YangKeao yangkeao@chunibyo.icu
Fix #2626, #2688
What problem does this PR solve?
This PR solves two problem:
cwd_replacer
works correctly now.toda
from recovery. It's because the processes are still waiting inside the latency. This PR makes the latency cancellable, and will interrupt the sleeping when it tries to resume.What's changed and how it works?
For the first problem, the
cwd_replacer
doesn't consider the situation when the process were inside the subdirectory of volume. It changes the cwd of processes into the root of the volume, which is not expected. The fix is quite simple, you can read the chaos-mesh/toda@7ca342b .For the second problem, you can read chaos-mesh/toda@65071a4 .