Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go to 1.17 #2754

Merged
merged 9 commits into from
Jan 12, 2022
Merged

bump go to 1.17 #2754

merged 9 commits into from
Jan 12, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Jan 6, 2022 •
edited

What problem does this PR solve?

It's a part of #2752, preparing for upgrading controller-runtime and kubernetes relates dependencies.

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@STRRL
chore: update go.mod to 1.17
5d94ff9 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
chore: update dockerfile and CI
3d568a8 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@STRRL STRRL mentioned this pull request Jan 6, 2022
Open
30 tasks
@STRRL STRRL changed the title chore: update go.mod to 1.17 bump go to 1.17 Jan 6, 2022
@STRRL STRRL added rebuild-build-env-image rebuild build-env image in this PR rebuild-dev-env-image rebuild dev-env image in this PR labels Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited

Codecov Report

Merging #2754 (15c79bb) into master (dff3b48) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2754      +/-   ##
==========================================
- Coverage   41.18%   41.14%   -0.04%     
==========================================
  Files         144      144              
  Lines       11719    11719              
==========================================
- Hits         4826     4822       -4     
- Misses       6532     6535       +3     
- Partials      361      362       +1
Impacted Files Coverage Δ
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67a709...15c79bb. Read the comment docs.

@STRRL
chore: update go.mod
60d7f46 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot ti-chi-bot added size/XL and removed size/M labels Jan 6, 2022
@STRRL
chore: make check
554ae7d 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL marked this pull request as ready for review January 6, 2022 11:19
@STRRL
Copy link
Member Author

STRRL commented Jan 6, 2022

PTAL

/cc @cwen0 @WangXiangUSTC @YangKeao @Hexilee @iguoyr @g1eny0ung

@STRRL
chore: cleanup old // +build build constraints
c334709 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
Merge remote-tracking branch 'upstream/master' into use-go-1.17
b2d0a6a 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
chore: make check
a944f90 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL
Copy link
Member Author

STRRL commented Jan 10, 2022

Updated PTAL @cwen0 @YangKeao

@STRRL STRRL requested a review from cwen0 January 10, 2022 08:54
@Andrewmatilde
Copy link
Member

/run-e2e-test

Andrewmatilde
Andrewmatilde approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YangKeao
YangKeao approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15c79bb

@cwen0
Copy link
Member

cwen0 commented Jan 12, 2022

/run-e2e-tests

@STRRL
Copy link
Member Author

STRRL commented Jan 12, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit ce45054 into chaos-mesh:master Jan 12, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@STRRL
Copy link
Member Author

STRRL commented Jan 12, 2022

cherry pick to release-2.1 failed

I would cherry-pick to release-2.1 manually.

@STRRL STRRL deleted the use-go-1.17 branch January 12, 2022 04:45
STRRL added a commit to STRRL/chaos-mesh that referenced this pull request Jan 12, 2022
@STRRL @g1eny0ung @YangKeao
bump go to 1.17 (chaos-mesh#2754)
a6be9ea 
* chore: update go.mod to 1.17

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update dockerfile and CI

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update go.mod

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: cleanup old // +build build constraints

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: YangKeao <keao.yang@yahoo.com>
@STRRL STRRL mentioned this pull request Jan 12, 2022
Merged
ti-chi-bot pushed a commit that referenced this pull request Jan 12, 2022
@STRRL @g1eny0ung @YangKeao
Cherry pick #2754 to release 2.1 (#2777)
f2ff93a 
* chore: update go.mod to 1.17

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update dockerfile and CI

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update go.mod

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: cleanup old // +build build constraints

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: YangKeao <keao.yang@yahoo.com>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: YangKeao <keao.yang@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@Andrewmatilde Andrewmatilde Andrewmatilde approved these changes

@Hexilee Hexilee Awaiting requested review from Hexilee

@g1eny0ung g1eny0ung Awaiting requested review from g1eny0ung

@iguoyr iguoyr Awaiting requested review from iguoyr

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

@cwen0 cwen0 Awaiting requested review from cwen0

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 rebuild-build-env-image rebuild build-env image in this PR rebuild-dev-env-image rebuild dev-env image in this PR size/XL status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@STRRL @ti-chi-bot @Andrewmatilde @YangKeao @cwen0 @ti-srebot @g1eny0ung