Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix environment variables in build scripts #2771

Merged
merged 2 commits into from
Jan 11, 2022
Merged

build: fix environment variables in build scripts #2771

merged 2 commits into from
Jan 11, 2022

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

  1. Don't override environment variable in the build-script
  2. Pass environment variable like HTTP_PROXY and HTTPS_PROXY... to the dev environment.

@YangKeao
pass environment variable to build scripts
87a0e17 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
pass _PROXY to the dev-env
971166a 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Hexilee
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao YangKeao requested review from cwen0, fewdan and Hexilee and removed request for yeya24 January 11, 2022 06:03
Hexilee
Hexilee approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member Author

/run-e2e-tests

cwen0
cwen0 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jan 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 971166a

@ti-chi-bot ti-chi-bot merged commit 723a822 into chaos-mesh:master Jan 11, 2022
@STRRL STRRL mentioned this pull request Jan 13, 2022
Closed
51 tasks
@STRRL STRRL added this to the Release 2.2 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@Hexilee Hexilee Hexilee approved these changes

@fewdan fewdan Awaiting requested review from fewdan

Assignees
No one assigned
Labels
size/S status/can-merge status/LGT2
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YangKeao @ti-chi-bot @cwen0 @Hexilee @STRRL