Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update checklink config #2774

Merged
merged 3 commits into from
Jan 11, 2022
Merged

chore: update checklink config #2774

merged 3 commits into from
Jan 11, 2022

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Jan 11, 2022 •
edited

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

We currently use gaurav-nelson/github-action-markdown-link-check@v1 to check all markdown links. At first, we only want to check for link errors (usually 404) due to our reasons. But, for some unknowable reason, such as a server IP being banned or something, it will return a 403 error, which is out of our control.

What's changed and how it works?

This PR adds the "aliveStatusCodes": [200, 403, 500, 502, 503] to make the action meet our needs.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0
    • release-1.2
    • release-1.1

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@g1eny0ung
chore: update checklink config
c3a4f16 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • milasuperstar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@g1eny0ung g1eny0ung requested a review from cwen0 January 11, 2022 10:07
@g1eny0ung g1eny0ung requested a review from a team January 11, 2022 10:07
@g1eny0ung
chore: update
1f0147d 
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
cwen0
cwen0 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jan 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1f0147d

@cwen0
Copy link
Member

cwen0 commented Jan 11, 2022

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 4dd3e4f into chaos-mesh:master Jan 11, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-1.2 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot ti-srebot mentioned this pull request Jan 11, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2775

@g1eny0ung g1eny0ung deleted the chore/update-checklink-config branch January 11, 2022 12:47
ti-chi-bot added a commit that referenced this pull request Jan 12, 2022
@ti-srebot @g1eny0ung @ti-chi-bot
chore: update checklink config (#2774) (#2775)
eeb680e 
* chore: update checklink config

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@milasuperstar milasuperstar milasuperstar approved these changes

@Colstuwjx Colstuwjx Awaiting requested review from Colstuwjx

@iguoyr iguoyr Awaiting requested review from iguoyr

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 needs-cherry-pick-release-2.1 size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@g1eny0ung @ti-chi-bot @cwen0 @ti-srebot @milasuperstar