Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github.com/pkg/errors to replace fmt.Errorf and "errors" #2780

Merged
merged 12 commits into from
Jan 13, 2022
Merged

Use github.com/pkg/errors to replace fmt.Errorf and "errors" #2780

merged 12 commits into from
Jan 13, 2022

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

The first step of #2779

@YangKeao
turn to use pkg/errors rather than fmt or errors
0475e5b 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Merge remote-tracking branch 'upstream/master' into refine-error-handle
303f2c9 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao YangKeao mentioned this pull request Jan 12, 2022
Closed
4 tasks
@YangKeao
use wrap to wrap the error
c175b71 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@codecov
Copy link

codecov bot commented Jan 12, 2022 •
edited

Codecov Report

Merging #2780 (3f50e7f) into master (857bcc7) will increase coverage by 0.22%.
The diff coverage is 28.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
+ Coverage   40.90%   41.13%   +0.22%     
==========================================
  Files         144      144              
  Lines       11738    11744       +6     
==========================================
+ Hits         4802     4831      +29     
+ Misses       6572     6551      -21     
+ Partials      364      362       -2
Impacted Files Coverage Δ
api/v1alpha1/networkchaos_webhook.go 81.35% <ø> (ø)
api/v1alpha1/stresschaos_webhook.go 32.07% <ø> (ø)
api/v1alpha1/workflow_types.go 7.69% <0.00%> (ø)
api/v1alpha1/workflow_webhook.go 44.14% <0.00%> (ø)
api/v1alpha1/zz_generated.chaosmesh.go 57.62% <ø> (ø)
api/v1alpha1/zz_generated.schedule.chaosmesh.go 0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.workflow.chaosmesh.go 5.09% <0.00%> (ø)
api/webhook/validate_auth.go 0.00% <0.00%> (ø)
cmd/chaos-builder/impl.go 0.00% <ø> (ø)
cmd/chaos-builder/main.go 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214c098...3f50e7f. Read the comment docs.

@STRRL
Copy link
Member

STRRL commented Jan 12, 2022

Hi @YangKeao , please fix the CI

STRRL
STRRL reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

api/v1alpha1/awschaos_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/awschaos_webhook.go Outdated Show resolved Hide resolved
controllers/chaosimpl/utils/record.go Outdated Show resolved Hide resolved
ui/.husky/pre-commit Outdated Show resolved Hide resolved
YangKeao and others added 5 commits January 12, 2022 18:40
@YangKeao
fix CI and test
f454c0a 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
restore yarn.lock
b393293 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
replace "is empty" to "is required" in webhook message
0dafa26 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
make check!
de53736 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@STRRL
Merge branch 'master' into refine-error-handle
3d36ea7
@YangKeao YangKeao requested a review from STRRL January 13, 2022 05:01
@YangKeao
Copy link
Member Author

/run-e2e-tests

STRRL
STRRL approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

WangXiangUSTC
WangXiangUSTC reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/dashboard/apiserver/archive/archive.go Outdated Show resolved Hide resolved
pkg/dashboard/apiserver/archive/archive.go Outdated Show resolved Hide resolved
pkg/webhook/config/config.go Show resolved Hide resolved
@YangKeao
replace errors.Errorf
3f50e7f 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
WangXiangUSTC
WangXiangUSTC approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3f50e7f

@ti-chi-bot ti-chi-bot merged commit 01f298e into chaos-mesh:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1eny0ung g1eny0ung g1eny0ung left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 Awaiting requested review from cwen0

Assignees
No one assigned
Labels
size/XXL status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YangKeao @ti-chi-bot @STRRL @WangXiangUSTC @g1eny0ung