Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the description of GCPChaos #2791

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Jan 14, 2022

Signed-off-by: cwen0 cwenyin0@gmail.com

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2791 (e6c09c6) into master (01f298e) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2791      +/-   ##
==========================================
+ Coverage   40.82%   41.03%   +0.21%     
==========================================
  Files         144      144              
  Lines       11744    11744              
==========================================
+ Hits         4794     4819      +25     
+ Misses       6585     6563      -22     
+ Partials      365      362       -3     
Impacted Files Coverage Δ
api/v1alpha1/gcpchaos_types.go 0.00% <ø> (ø)
pkg/workflow/controllers/utils.go 85.71% <0.00%> (-1.59%) ⬇️
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (+2.29%) ⬆️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️
.../workflow/controllers/workflow_entry_reconciler.go 55.02% <0.00%> (+8.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f298e...e6c09c6. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@STRRL
Copy link
Member

STRRL commented Jan 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6c09c6

@cwen0
Copy link
Member Author

cwen0 commented Jan 14, 2022

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 152f665 into chaos-mesh:master Jan 14, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2793

@cwen0 cwen0 deleted the fix-gcp-docs branch January 14, 2022 09:20
ti-chi-bot pushed a commit that referenced this pull request Jan 15, 2022
* docs: fix the description of GCPChaos

Signed-off-by: cwen0 <cwenyin0@gmail.com>

* fix ci

Signed-off-by: cwen0 <cwenyin0@gmail.com>

Co-authored-by: cwen0 <cwenyin0@gmail.com>
cwen0 added a commit to cwen0/chaos-mesh that referenced this pull request Jan 19, 2022
… release-2.0)

Signed-off-by: cwen0 <cwenyin0@gmail.com>
cwen0 added a commit to cwen0/chaos-mesh that referenced this pull request Jan 19, 2022
… release-2.0)

Signed-off-by: cwen0 <cwenyin0@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Jan 25, 2022
Signed-off-by: cwen0 <cwenyin0@gmail.com>

Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants