Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use development logger for chaos-builder #2806

Merged

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Jan 19, 2022

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

human unreadable time in chaos-builder's log.

What's changed and how it works?

use the default development configuration for zap.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #2806 (d3dd870) into master (618a4cb) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2806      +/-   ##
==========================================
- Coverage   41.13%   41.07%   -0.06%     
==========================================
  Files         146      146              
  Lines       11868    11868              
==========================================
- Hits         4882     4875       -7     
- Misses       6620     6627       +7     
  Partials      366      366              
Impacted Files Coverage Δ
cmd/chaos-builder/main.go 0.00% <ø> (ø)
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
pkg/workflow/controllers/utils.go 85.71% <0.00%> (-1.59%) ⬇️
pkg/selector/generic/mode.go 28.20% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618a4cb...d3dd870. Read the comment docs.

Signed-off-by: STRRL <str_ruiling@outlook.com>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d3dd870

@YangKeao
Copy link
Member

/run-e2e-tests

1 similar comment
@STRRL
Copy link
Member Author

STRRL commented Jan 20, 2022

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit ea9c6cc into chaos-mesh:master Jan 20, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #2809

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2810

ti-chi-bot pushed a commit that referenced this pull request Jan 21, 2022
* chore: use development logger for chaos-builder

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: STRRL <str_ruiling@outlook.com>
ti-chi-bot added a commit that referenced this pull request Jan 24, 2022
* chore: use development logger for chaos-builder

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: STRRL <str_ruiling@outlook.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
rksharma95 pushed a commit to rksharma95/chaos-mesh that referenced this pull request Jan 26, 2022
* chore: use development logger for chaos-builder

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make check

Signed-off-by: STRRL <str_ruiling@outlook.com>
Signed-off-by: rksharma95 <nikhilrk13jan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants