-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use development logger for chaos-builder #2806
chore: use development logger for chaos-builder #2806
Conversation
Signed-off-by: STRRL <str_ruiling@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
==========================================
- Coverage 41.13% 41.07% -0.06%
==========================================
Files 146 146
Lines 11868 11868
==========================================
- Hits 4882 4875 -7
- Misses 6620 6627 +7
Partials 366 366
Continue to review full report at Codecov.
|
Signed-off-by: STRRL <str_ruiling@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d3dd870
|
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
cherry pick to release-2.0 in PR #2809 |
cherry pick to release-2.1 in PR #2810 |
* chore: use development logger for chaos-builder Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make check Signed-off-by: STRRL <str_ruiling@outlook.com> Co-authored-by: STRRL <str_ruiling@outlook.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* chore: use development logger for chaos-builder Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make check Signed-off-by: STRRL <str_ruiling@outlook.com> Signed-off-by: rksharma95 <nikhilrk13jan@gmail.com>
Signed-off-by: STRRL str_ruiling@outlook.com
What problem does this PR solve?
human unreadable time in chaos-builder's log.
What's changed and how it works?
use the default development configuration for zap.
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: