Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurechaos: support vm stop/restart and detach disk #2821

Merged
merged 32 commits into from
Mar 15, 2022
Merged

azurechaos: support vm stop/restart and detach disk #2821

merged 32 commits into from
Mar 15, 2022

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Jan 24, 2022

What problem does this PR solve?

add azurechaos

What's changed and how it works?

support vm stop/restart and detach disk

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@fewdan
azurechaos
f8e8a3f 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
Merge remote-tracking branch 'upstream/master' into azure2.0
fe0045c
@fewdan
update
2414847 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
update
132e482 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
make check
4e2ce01 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
update
64e1ac0 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@fewdan
Merge remote-tracking branch 'upstream/master' into azure2.0
8dc8b70
@fewdan
update license
4ce27ab 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
update license
dadd651 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@codecov
Copy link

codecov bot commented Jan 24, 2022 •
edited

Codecov Report

Merging #2821 (dbcb395) into master (2ba4962) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
+ Coverage   38.05%   38.22%   +0.16%     
==========================================
  Files         105      105              
  Lines        9094     9094              
==========================================
+ Hits         3461     3476      +15     
+ Misses       5327     5312      -15     
  Partials      306      306
Impacted Files Coverage Δ
pkg/selector/generic/mode.go 25.64% <0.00%> (-2.57%) ⬇️
.../workflow/controllers/workflow_entry_reconciler.go 55.02% <0.00%> (+8.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba4962...dbcb395. Read the comment docs.

@fewdan
update
618a62a 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@g1eny0ung g1eny0ung added chaos/azure feature/new Introduce a new feature labels Jan 25, 2022
@g1eny0ung g1eny0ung changed the title azurechao: support vm stop/restart and detach disk azurechaos: support vm stop/restart and detach disk Jan 25, 2022
@fewdan
update
0bbc56d 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
fmt
f2812f8 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
Merge remote-tracking branch 'upstream/master' into azure2.0
a31454a
@fewdan
fix IU
b4efd3f 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
fix UI
1e3631f 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
update
bc768cd 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@fewdan
Merge remote-tracking branch 'upstream/master' into azure2.0
43e29f9
@fewdan
make yaml
c4d1798 
Signed-off-by: “fewdan” <fewdan@hotmail.com>
@FingerLeader FingerLeader self-requested a review January 25, 2022 10:16
@fewdan
Copy link
Member Author

fewdan commented Feb 14, 2022

@FingerLeader PTAL at your earliest convenience, thanks.

Andrewmatilde
Andrewmatilde approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL STRRL mentioned this pull request Mar 2, 2022
Closed
51 tasks
FingerLeader and others added 3 commits March 11, 2022 11:39
@FingerLeader
Merge branch 'master' into azure2.0
6baa024
@FingerLeader
get authorizer from secret
54fb13e 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@STRRL
chore: make check
e228da8 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@FingerLeader
Copy link
Member

/run-e2e-test

WangXiangUSTC
WangXiangUSTC reviewed Mar 14, 2022
View reviewed changes
api/v1alpha1/azurechaos_types.go Show resolved Hide resolved
api/v1alpha1/azurechaos_webhook.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/diskdetach/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/diskdetach/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/diskdetach/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/diskdetach/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/vmrestart/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/vmstop/impl.go Outdated Show resolved Hide resolved
controllers/chaosimpl/azurechaos/vmstop/impl.go Outdated Show resolved Hide resolved
FingerLeader and others added 6 commits March 14, 2022 22:22
@FingerLeader
add command for GetAuthorizer
79e1106 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
update comments of validate
f97927b 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
add error handling for json unmarshal
418ae64 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
edit some details
93d67e7 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Merge branch 'master' into azure2.0
f7bd78a
@FingerLeader
edit some details
868666d 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
WangXiangUSTC
WangXiangUSTC approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FingerLeader
add error handling for json unmarshal
dbcb395 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Copy link
Member

/run-e2e-test

@FingerLeader
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dbcb395

@ti-chi-bot ti-chi-bot merged commit 8d8ed48 into chaos-mesh:master Mar 15, 2022
@STRRL STRRL mentioned this pull request Apr 14, 2022
Closed
@STRRL STRRL added this to the Release 2.2 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@Andrewmatilde Andrewmatilde Andrewmatilde approved these changes

@YangKeao YangKeao Awaiting requested review from YangKeao

@FingerLeader FingerLeader Awaiting requested review from FingerLeader

@cwen0 cwen0 Awaiting requested review from cwen0

Assignees
No one assigned
Labels
chaos/azure feature/new Introduce a new feature size/XXL status/can-merge status/LGT2
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fewdan @ti-chi-bot @FingerLeader @WangXiangUSTC @Andrewmatilde @g1eny0ung @STRRL