-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix podhttpchaos: check observedGeneration to avoid duplicated applying #2839
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2839 +/- ##
=======================================
Coverage 40.83% 40.83%
=======================================
Files 147 147
Lines 11985 11985
=======================================
Hits 4894 4894
Misses 6721 6721
Partials 370 370
Continue to review full report at Codecov.
|
Signed-off-by: xixi <i@hexilee.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ecde103
|
cherry pick to release-2.0 in PR #2851 |
cherry pick to release-2.1 in PR #2852 |
…ng (chaos-mesh#2839) Signed-off-by: xixi <i@hexilee.me> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: zhqqqy <zhqqqy@163.com>
Signed-off-by: xixi i@hexilee.me
What problem does this PR solve?
Now, the controller of PodHttpChaos applies rules in each time reconciling. We should check the observedGeneration to avoid duplicated applying.
What's changed and how it works?
Add checking block:
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: