Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalMachineChaos: add validate for network bandwidth #2850

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Feb 7, 2022

Signed-off-by: xiang xiang13225080@163.com

What problem does this PR solve?

fix issue: #2813

What's changed and how it works?

add validate for network bandwidth

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@@ -131,8 +133,6 @@ func (in *PhysicalMachineChaosSpec) Validate(root interface{}, path *field.Path)
case PMClockAction:
validateConfigErr = validateClockAction(in.Clock)
default:
allErrs = append(allErrs,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action already checked here, so removed it

// +kubebuilder:validation:Enum=stress-cpu;stress-mem;disk-read-payload;disk-write-payload;disk-fill;network-corrupt;network-duplicate;network-loss;network-delay;network-partition;network-dns;network-bandwidth;process;jvm-exception;jvm-gc;jvm-latency;jvm-return;jvm-stress;jvm-rule-data;clock

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2850 (55621a7) into master (149e540) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   40.93%   40.83%   -0.11%     
==========================================
  Files         147      147              
  Lines       11983    11991       +8     
==========================================
- Hits         4905     4896       -9     
- Misses       6708     6725      +17     
  Partials      370      370              
Impacted Files Coverage Δ
api/v1alpha1/physical_machine_chaos_types.go 46.15% <ø> (ø)
api/v1alpha1/physical_machine_chaos_webhook.go 86.54% <0.00%> (-2.18%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
.../workflow/controllers/workflow_entry_reconciler.go 48.14% <0.00%> (-4.77%) ⬇️
...g/workflow/controllers/parallel_node_reconciler.go 61.53% <0.00%> (-1.93%) ⬇️
pkg/workflow/controllers/utils.go 87.30% <0.00%> (+1.58%) ⬆️
pkg/workflow/controllers/chaos_node_reconciler.go 58.16% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2854f0...55621a7. Read the comment docs.

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5161543

@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit f3e2951 into chaos-mesh:master Feb 15, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

mikechengwei pushed a commit to mikechengwei/chaos-mesh that referenced this pull request Feb 21, 2022
…2850)

* add validate for network bandwidth

Signed-off-by: xiang <xiang13225080@163.com>

* add changelog

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: mikechengwei <842725815@qq.com>
zhqqqy pushed a commit to zhqqqy/chaos-mesh that referenced this pull request Apr 10, 2022
…2850)

* add validate for network bandwidth

Signed-off-by: xiang <xiang13225080@163.com>

* add changelog

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: zhqqqy <zhqqqy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants