-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhysicalMachineChaos: add validate for network bandwidth #2850
PhysicalMachineChaos: add validate for network bandwidth #2850
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -131,8 +133,6 @@ func (in *PhysicalMachineChaosSpec) Validate(root interface{}, path *field.Path) | |||
case PMClockAction: | |||
validateConfigErr = validateClockAction(in.Clock) | |||
default: | |||
allErrs = append(allErrs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action already checked here, so removed it
// +kubebuilder:validation:Enum=stress-cpu;stress-mem;disk-read-payload;disk-write-payload;disk-fill;network-corrupt;network-duplicate;network-loss;network-delay;network-partition;network-dns;network-bandwidth;process;jvm-exception;jvm-gc;jvm-latency;jvm-return;jvm-stress;jvm-rule-data;clock |
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
- Coverage 40.93% 40.83% -0.11%
==========================================
Files 147 147
Lines 11983 11991 +8
==========================================
- Hits 4905 4896 -9
- Misses 6708 6725 +17
Partials 370 370
Continue to review full report at Codecov.
|
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5161543
|
/run-e2e-tests |
cherry pick to release-2.1 failed |
…2850) * add validate for network bandwidth Signed-off-by: xiang <xiang13225080@163.com> * add changelog Signed-off-by: xiang <xiang13225080@163.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: mikechengwei <842725815@qq.com>
…2850) * add validate for network bandwidth Signed-off-by: xiang <xiang13225080@163.com> * add changelog Signed-off-by: xiang <xiang13225080@163.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: zhqqqy <zhqqqy@163.com>
Signed-off-by: xiang xiang13225080@163.com
What problem does this PR solve?
fix issue: #2813
What's changed and how it works?
add validate for network bandwidth
Related changes
chaos-mesh/website
Dashboard UI
Checklist
Tests
Side effects
Release note
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: