Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some errors in install.sh #2858

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

This PR fixes some bugs introduced by #2797:

  • Re-add incorrectly deleted deploy_volume_provisioner
  • Remove unused local vars

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL
Copy link
Member

STRRL commented Feb 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aab46a2

@ti-chi-bot ti-chi-bot merged commit 712f58c into chaos-mesh:master Feb 8, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 failed

@g1eny0ung g1eny0ung deleted the fix/install.sh branch February 8, 2022 11:06
g1eny0ung added a commit to g1eny0ung/chaos-mesh that referenced this pull request Feb 9, 2022
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
g1eny0ung added a commit to g1eny0ung/chaos-mesh that referenced this pull request Feb 9, 2022
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Feb 9, 2022
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Feb 9, 2022
* fix: some errors in install.sh #2858

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: ci

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
zhqqqy pushed a commit to zhqqqy/chaos-mesh that referenced this pull request Apr 10, 2022
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: zhqqqy <zhqqqy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants