Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mode on physical machine chaos #2866

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

iguoyr
Copy link
Member

@iguoyr iguoyr commented Feb 9, 2022

Signed-off-by: SiyuChen ryougi201@gmail.com

What problem does this PR solve?

Close #2816

What's changed and how it works?

add mode input box on physical machine chaos

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: SiyuChen <ryougi201@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@iguoyr iguoyr requested review from STRRL and removed request for fewdan February 9, 2022 08:32
@g1eny0ung g1eny0ung added component/ui type/bug-fix A bug needs to be fixed. labels Feb 9, 2022
Signed-off-by: SiyuChen <ryougi201@gmail.com>
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM 👍🏽

ui/app/src/components/NewExperimentNext/Step1.tsx Outdated Show resolved Hide resolved
Signed-off-by: SiyuChen <ryougi201@gmail.com>
@iguoyr
Copy link
Member Author

iguoyr commented Feb 10, 2022

/cc @STRRL @WangXiangUSTC
PTAL

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 765658d

@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2894

g1eny0ung pushed a commit that referenced this pull request Feb 14, 2022
* fix: support mode on physical machine chaos

Signed-off-by: SiyuChen <ryougi201@gmail.com>

* chore: fix handleSwitchEnv type

Signed-off-by: SiyuChen <ryougi201@gmail.com>

* chore: update

Signed-off-by: SiyuChen <ryougi201@gmail.com>

Co-authored-by: SiyuChen <ryougi201@gmail.com>
@iguoyr iguoyr deleted the physical-machine-mode branch March 17, 2022 05:55
zhqqqy pushed a commit to zhqqqy/chaos-mesh that referenced this pull request Apr 10, 2022
* fix: support mode on physical machine chaos

Signed-off-by: SiyuChen <ryougi201@gmail.com>

* chore: fix handleSwitchEnv type

Signed-off-by: SiyuChen <ryougi201@gmail.com>

* chore: update

Signed-off-by: SiyuChen <ryougi201@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: zhqqqy <zhqqqy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhysicalMachineChaos: spec.mode: Unsupported value: ""
6 participants