-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chaos-daemon: remove host ipc #2869
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
For HTTPChaos, the e2e-test fails to dial the helper.
|
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
/run-e2e-tests |
What does this mean? I saw the e2e tests succeed. Only not work in rootless containers? |
Yes. (But I don't know why actually. It needs more investigation, but it's fine to merge this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Do these chaos types work well if set |
No. |
@cwen0 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 220fd90
|
What problem does this PR solve?
Fix #2845 . With
hostIPC
, the/dev/shm
on the host will be mounted to the container. As I know, thehostIPC
was brought withTimeChaos
, and I'm not sure whether it's really needed, we can see in the test.A more surprising thing is that even with
priviledged
, thechaos-daemon
can successfully start. As I have tested, the following chaos works well:The following chaos doesn't work:
Need further discussion about why they didn't work. I noticed that the sidecar injection test also fails.