-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make time chaos completely recoverable #2942
Conversation
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
# Conflicts: # pkg/time/time_skew_amd64.go
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
# Conflicts: # pkg/chaosdaemon/pb/chaosdaemon.pb.go # pkg/chaosdaemon/server.go # pkg/chaosdaemon/time_server.go # pkg/time/fake_image.go
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
# Conflicts: # cmd/watchmaker/main_linux_amd64.go
Codecov Report
@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
- Coverage 38.10% 37.18% -0.93%
==========================================
Files 106 106
Lines 9359 9634 +275
==========================================
+ Hits 3566 3582 +16
- Misses 5481 5732 +251
- Partials 312 320 +8
Continue to review full report at Codecov.
|
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
# Conflicts: # pkg/chaosdaemon/time_server_test.go
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I cannot come up with a better idea. LGTM
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3633ec6
|
What problem does this PR solve?
Time chaos cannot completely recover now.
Time chaos cannot combine chaos effect now.
What's changed and how it works?
Main:
After time_skew or recover_time_skew the status of target process will conform to the expected.
Example: time_skew(1h) + time_skew(1h) + recover_(time_skew(1h)) -> time_skew(1h)
Other:
Add a nice common error package in
pkg/cerr/..
Checklist
Tests