Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue that StackOverflow error will appear when byteman injec… #2945

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Fix the issue that StackOverflow error will appear when byteman injec… #2945

merged 2 commits into from
Mar 4, 2022

Conversation

zhqqqy
Copy link
Contributor

@zhqqqy zhqqqy commented Feb 25, 2022

…ts some rules again

What problem does this PR solve?

Open #2923

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • [ x ] Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note 

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 25, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • fewdan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @zhqqqy!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

@zhqqqy zhqqqy mentioned this pull request Feb 25, 2022
Closed
@WangXiangUSTC
Copy link
Contributor

Thanks! Please fix the DCO ci

git commit --amend --signoff
git push --force

@codecov
Copy link

codecov bot commented Feb 25, 2022 •
edited

Codecov Report

Merging #2945 (c9a50d4) into master (b9e3519) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
+ Coverage   37.27%   37.37%   +0.09%     
==========================================
  Files         110      110              
  Lines        9427     9427              
==========================================
+ Hits         3514     3523       +9     
+ Misses       5598     5588      -10     
- Partials      315      316       +1
Impacted Files Coverage Δ
pkg/chaosdaemon/jvm_server.go 0.00% <ø> (ø)
.../workflow/controllers/workflow_entry_reconciler.go 52.91% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2156457...c9a50d4. Read the comment docs.

@WangXiangUSTC
Copy link
Contributor

ping @zhqqqy

Fix the issue that StackOverflow error will appear when byteman injec…
8690b6f 
…ts some rules again

Signed-off-by: zhaohaiqiang <zhaohaiqiang@youzan.com>
@zhqqqy zhqqqy force-pushed the improve/add-compileToBytecode branch from 9d71b2f to 8690b6f Compare March 2, 2022 02:54
WangXiangUSTC
WangXiangUSTC approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fewdan
fewdan approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8690b6f

@ti-chi-bot ti-chi-bot merged commit d212a81 into chaos-mesh:master Mar 4, 2022
afzal442 pushed a commit to afzal442/chaos-mesh that referenced this pull request Mar 19, 2022
@zhqqqy @ti-chi-bot @afzal442
Fix the issue that StackOverflow error will appear when byteman injec… (
f2e87ed 
chaos-mesh#2945)

Signed-off-by: zhaohaiqiang <zhaohaiqiang@youzan.com>

Co-authored-by: zhaohaiqiang <zhaohaiqiang@youzan.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@WangXiangUSTC WangXiangUSTC mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@fewdan fewdan fewdan approved these changes

@cwen0 cwen0 Awaiting requested review from cwen0

@yeya24 yeya24 Awaiting requested review from yeya24

Assignees
No one assigned
Labels
contribution first-time-contributor size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhqqqy @ti-chi-bot @WangXiangUSTC @fewdan